shop parameters refactoring