Ah yes, you're right.


On Fri, Mar 7, 2014 at 5:16 AM, myrdd <notifications@github.com> wrote:

> In horizons/gui/windows.py:
>
> > @@ -316,7 +330,7 @@ def toggle(self, window, **kwargs):
> >  		else:
> >  			if window in self._windows:
> >  				self._windows.remove(window)
> > -			self.show(window, **kwargs)
> > +			self.open(window, **kwargs)
>
> I think this should be instead
>
>                         if window in self._windows:
>                                 self._windows.remove(window)
>                                 self._windows[-1].hide()
>                                 self._windows.append(window)
>                                 window.show(**kwargs)
>                         else:
>                                 self.open(window, **kwargs)
>
> so that Window.open() is only called if the window wasn't in the stack
> before.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/unknown-horizons/unknown-horizons/pull/2266/files#r10373035>
> .
>