Extended IManagedMessageFailures to include numberOfAttempts

Refactored FaultManager to create proper error messages in case FLR is disabled.
Go ahead and try

On Wed, Oct 1, 2014 at 6:28 AM, Szymon Pobiega <notifications@github.com>
wrote:

> In src/NServiceBus.Core/Faults/IManageMessageFailures.cs:
>
> > @@ -15,7 +15,7 @@ public interface IManageMessageFailures
> >          /// <summary>
> >          /// Invoked when a message has failed its processing the maximum number of time configured.
> >          /// </summary>
> > -        void ProcessingAlwaysFailsForMessage(TransportMessage message, Exception e);
> > +        void ProcessingAlwaysFailsForMessage(TransportMessage message, Exception e, int numberOfAttempts);
>
> The NServiceBus.Retries header is used for SLR. Should I use
> NServiceBus.FLRetries? (assuming attempts == retries + 1)
> … <#148cb41704633944_>
> On Wed, Oct 1, 2014 at 12:24 PM, Andreas Öhlund <notifications@github.com>
> wrote: In src/NServiceBus.Core/Faults/IManageMessageFailures.cs: > @@ -15,7
> +15,7 @@ public interface IManageMessageFailures > /// <summary> > ///
> Invoked when a message has failed its processing the maximum number of time
> configured. > /// </summary> > - void
> ProcessingAlwaysFailsForMessage(TransportMessage message, Exception e); > +
> void ProcessingAlwaysFailsForMessage(TransportMessage message, Exception e,
> int numberOfAttempts); Could we use a header instead to avoid the breaking
> change for now? … <#148cb3d1b47d4707_> On Wed, Oct 1, 2014 at 5:52 AM,
> Szymon Pobiega <notifications@github.com> wrote: In
> src/NServiceBus.Core/Faults/IManageMessageFailures.cs: > @@ -15,7 +15,7 @@
> public interface IManageMessageFailures > /// <summary> > /// Invoked when
> a message has failed its processing the maximum number of time configured.
> > /// </summary> > - void ProcessingAlwaysFailsForMessage(TransportMessage
> message, Exception e); > + void
> ProcessingAlwaysFailsForMessage(TransportMessage message, Exception e, int
> numberOfAttempts); should I move the associated issue out of 5.1? — Reply
> to this email directly or view it on GitHub <
> https://github.com/Particular/NServiceBus/pull/2434/files#r18269476>. —
> Reply to this email directly or view it on GitHub <
> https://github.com/Particular/NServiceBus/pull/2434/files#r18270510>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Particular/NServiceBus/pull/2434/files#r18270683>.
>