#2588 - check in upgrade_master that rotateLength and maxRotatedFiles are valid

See http://trac.buildbot.net/ticket/2588.

This flags up invalid settings in the tac file during an upgrade.