Fix example how plugins can react on changes in project config

The example didn't handle the case that on project creation a zero
ObjectId is provided as old ObjectId.

RefNames.REFS_CONFIG has to be used instead of
GitRepositoryManager.REF_CONFIG which doesn't exist anymore.

Change-Id: Ic42ca72a126b70ff0b452e5150e2d1e3c916c73c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Bump Jetty version to stable 9.1 and Servlet API to 3.1

Change-Id: Ic6a374afa978e66ec1a04a2b39801da158ba31d7
Buck: Preserve SNAPSHOT suffix in Maven artifact names

Drop the code that removes SNAPSHOT suffix in artifact name. This prevents
Gitblit plugin from fetching its custom artifact from Gerritforge Maven
repository, making from the right name:

  com/gitblit/gitblit/1.4.0-SNAPSHOT/gitblit-1.4.0-SNAPSHOT.jar

the broken artifact name:

  com/gitblit/gitblit/1.4.0-SNAPSHOT/gitblit-1.4.0.jar

Change-Id: Ib16f032a9fda3ef61570a85d97659cd3ce02f5f2
SideBySide2: Map *.scala to clike CodeMirror mode

Bug: issue 2360
Change-Id: I5183cdafba52b1e5e0fa344026c5b597315a46e2
Buck: increase JVM heap size for acceptance tests

Change-Id: I43895bd881d69b36731d2abcefbe502f2e1b08f0
Add acceptance test for copying approvals between patch sets

Change-Id: Ice4a4356988ac8a61ea4cbc00493648444fc6e32
Merge "SideBySide2: Map *.scala to clike CodeMirror mode"
Merge "Buck: Preserve SNAPSHOT suffix in Maven artifact names"
Merge "Bump Jetty version to stable 9.1 and Servlet API to 3.1"
Fix Guice bindings in reindexer

Change-Id: I5922149171f082660fb1100bda0f1e161761ed6c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Extract an ApprovalCopier from ApprovalsUtil

Rewrite in such a way that we can do an implicit "copy" between
arbitrary patch sets without necessarily storing the results. For the
notedb, we will use this (with cached ChangeKinds) rather than storing
copied labels.

This introduces a few minor behavior changes. First, copied approvals
are now normalized according to permissions. This may result in
different values stored in the database when copying, but these values
were already normalized out by ChangeJson and the submit rule
evaluator, so this should not result in a semantic change.

Second, we no longer pass in a "source" patch set; all prior patch
sets are considered. This has the advantage that it does not rely on
labels having been properly copied to intermediate patch sets. It also
means, for example, if patch set 3 has a code change relative to patch
set 2 but not patch set 1, approvals on a copyAllScoresOnNoCodeChange
label will be copied from patch set 1, bypassing patch set 2. We think
this is a more correct state of affairs: if patch set 1 is good enough
to submit, so should patch set 3, regardless of the fact that there is
an intermediate patch set.

Change-Id: I56ae707c34ac7b978b06a0624c1353e8f28286a7
Clean left over data migration after removal of TrackingIds table

9f4de526dd3fec0400f6df53628956a4bf0d9033 removed TrackingIds table.
766e4415b0f004a4e53c93d256624361072c67c4 tries to swap primary key from
tracking_id to tracking_key in data migration method.

But because the table was removed from the Schema the TrackingIds is not
picked by gwtorm for the upgrade (ALTER TABLE add tracking_key statement).

In Schema_70 the migration step tries to execute:

  UPDATE tracking_ids SET tracking_key = tracking_id

and is failing because the column tracking_key wasn't created.

To rectify this, remove the migrate data method entirely in Schema_70.

Bug: Issue 2382
Change-Id: I1d7b6deb50be8595626d210a4350683d8b996de5
SideBySide2: Map *.scala to clike CodeMirror mode

Bug: issue 2360
Change-Id: I5183cdafba52b1e5e0fa344026c5b597315a46e2
Buck: Preserve SNAPSHOT suffix in Maven artifact names

Drop the code that removes SNAPSHOT suffix in artifact name. This prevents
Gitblit plugin from fetching its custom artifact from Gerritforge Maven
repository, making from the right name:

  com/gitblit/gitblit/1.4.0-SNAPSHOT/gitblit-1.4.0-SNAPSHOT.jar

the broken artifact name:

  com/gitblit/gitblit/1.4.0-SNAPSHOT/gitblit-1.4.0.jar

Change-Id: Ib16f032a9fda3ef61570a85d97659cd3ce02f5f2
Merge "Buck: Preserve SNAPSHOT suffix in Maven artifact names" into stable-2.8
Fix examples for Code-Review queries in search documentation

The Code-Review label is now called 'Code-Review' and not anymore
'CodeReview'.

Change-Id: I04c57107d2a4d4762216a09bca3c12a24c8916f0
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Revert "Scroll from the window when rendering entire file"

This reverts commit b07a26f2ebb24d1e9a9a20c7683fed55aab9a6bd.
Codemirror expects to be able to scroll Codemirror instance in
order to execute any line navigation. Furthermore, horizontal
scrollbars are rendered in the Codemirror at the bottom of the
document (not window). In order to have a "window" scroll bar,
we would likely have to steal the scroll bars inside Codemirror
and make it look like the window scroll bar.

Change-Id: I3199edc039ba716723eaf8032eaa5355c2100666
Merge "Clean left over data migration after removal of TrackingIds table"
Only recheck mergeable on reindex with a flag

The mergeability computation is expensive and should be redundant
after it's been run once. Protect this behavior with a flag that
defaults to false, and instruct users to run reindex with the flag in
the release notes.

Change-Id: I3c6140b9a727165b8b43712a0d162c530db048a6
Pass full PatchSet into ApprovalCopier

This is called from contexts where the new PatchSet is created and
inserted into the database, but transaction semantics in non-SQL
implementations do not guarantee it is able to be read back. We still
need it to get the commit SHA for change kind computation, so pass it
in.

Change-Id: I048453a39c405e5b4c185d3f1629fee4c9acae14