That PR does not blacklist codecs, it blacklists the settings.

On nvidia everything works fine, so don't bother the user with any settings
at all.

When you are a normal nvidia user, you don't want to see vaapi advanced
codec options -> so they are hidden.

If you are an AMD user, you need to see codec settings, cause some of them
crash your kernel - but only some - and different ones for different gpus.

So - the only thing an nvidia user with intel wrapper does not see is the
codec selection. That's all.

Unknown gpus see all options.


2014-02-02 Joakim Plate <notifications@github.com>:

> In xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodec.cpp:
>
> > +  }
> > +  else if (isIntel) // intel needs vc1, mpeg-2 and mpeg4 setting
> > +  {
> > +    if (settingId == "videoplayer.usevaapimpeg4")
> > +      return true;
> > +    if (settingId == "videoplayer.usevaapivc1")
> > +      return true;
> > +    if (settingId == "videoplayer.usevaapimpeg2")
> > +      return true;
> > +
> > +    return false; //this will also hide nvidia settings on intel hardware
> > +  }
> > +  // if we don't know the hardware we are running on e.g. amd oss vdpau
> > +  // or fglrx with xvba-driver we show everything
> > +  return true;
> > +}
>
> Maybe.. but it has benefits for testing things. Imho we should just have
> it prioritized lower. And blacklists for specific codecs should go into
> advanced settings.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/4011/files#r9370428>
> .
>



-- 
                   Key-ID:     0x1A995A9B
                   keyserver: pgp.mit.edu
==============================================================
Fingerprint: 4606 DA19 EC2E 9A0B 0157  C81B DA07 CF63 1A99 5A9B