I'll have a look at this as soon as I get some time.
It shouldn't be a massive piece of work to add that check in the puppet
manifests.

On 25/02/14 14:43, James Fryman wrote:
> In templates/vhost/vhost_location_proxy.erb:
> 
>> @@ -17,6 +17,9 @@
>>  <% end -%>
>>      proxy_pass          <%= @proxy %>;
>>      proxy_read_timeout  <%= @proxy_read_timeout %>;
>> +<% if @proxy_redirect_fromhost and @proxy_redirect_tohost -%>
> 
> Neat! The check in this template is going to look for both variables to
> be defined, however there is no check in the actual manifest itself to
> error/warn if only one half of the variables are defined. What do you
> think about adding a warning in |vhost.pp| so a user doesn't have to go
> digging too far if they misconfigure in some way?
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jfryman/puppet-nginx/pull/262/files#r10037727>.
>