CP-9906: Raise a ref rather than a UUID for VDI_NOT_IN_MAP

The CLI code has the ability to turn the ref into a UUID.

Signed-off-by: John Else <john.else@citrix.com>
CP-9906: Improve SXM failure logging

Log that we don't know to where a VDI should be copied.

Signed-off-by: John Else <john.else@citrix.com>
CP-9906: Improve SXM failure error reporting

Raise a proper Api_error if we've failed to determine the destination to
which a snapshot VDI should be migrated.

Signed-off-by: John Else <john.else@citrix.com>
Revert "CA-146698: xe vm-retrieve-wlb-recommendations does not print WLB ZeroScoreReason"

This reverts commit 5ddbf8a3b985bb2bf6a59bfb786cf74af53b4162.
CA-147800: VMStart/TC8561: Guest did not start/resume where expected.
CA-146698(https://github.com/xapi-project/xen-api/pull/1961) is not a
complete fix, xapi_vm_helpers.ml#695 pattern matching also should be
changed. Some XenRT case was broken, so revert its code changes.

Signed-off-by: Phus Lu <phus.lu@citrix.com>
Merge pull request #1975 from phusl/CA-147800

Revert "CA-146698: xe vm-retrieve-wlb-recommendations does not print WLB ZeroScoreReason"
Merge pull request #1973 from johnelse/sxm-workaround-xs64bit

Improvements to SXM failure logging and error reporting
Extend the VDI map rather than replace it

This helps with CA-143836, and allows specification of a snapshot
VDI in the map.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
When performing a snapshot using the SMAPI, set is_a_snapshot

This is usually fixed up after the fact, either in xapi_vdi.ml
in the case of a normal VDI snapshot, or in update_snapshot_info_dest.
If the snapshot_of information is missing though, this does not
get set.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Merge pull request #1990 from jonludlam/CA-143836-workaround

CA-143836 workaround
Revert "CA-98090: Block SXM when VM cannot match any bridge names on destination"
Merge pull request #1992 from xapi-project/revert-1715-ca-98090-xs64bit

Revert "CA-98090: Block SXM when VM cannot match any bridge names on des...
CA-127274: Linux bridge: set forwarding delay to 0 after creating a bridge

The forwarding delay is 30s by default, which means that for the first 30s
after bringing up a bridge port, the port will be in "learning mode", and won't
forward any packets. We want bridge ports to immediately go in "forwarding
mode" instead.

We did this in the past, but it was lost in the transition to xcp-networkd.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Merge pull request #1994 from robhoes/xs64bit-ring3

CA-127274: Linux bridge: set forwarding delay to 0 after creating a bridge
CA-149823: Reinstate bridge_not_available error for b/w compatibility

Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
Merge pull request #1995 from simonjbeaumont/ca-149823

CA-149823: Reinstate bridge_not_available error for b/w compatibility