Thanks Ben, will fix.
On Feb 10, 2014 6:55 PM, "Ben Noordhuis" <notifications@github.com> wrote:

> In src/unix/process.c:
>
> > @@ -330,6 +330,20 @@ static void uv__process_child_init(const uv_process_options_t* options,
> >      _exit(127);
> >    }
> >
> > +  if (options->flags & (UV_PROCESS_SETUID | UV_PROCESS_SETGID)) {
> > +    /* When dropping privileges from root, the `setgroups` call will
> > +     * remove any extraneous groups. If we don't call this, then
> > +     * even though our uid has dropped, we may still have groups
> > +     * that enable us to do super-user things. This will fail if we
> > +     * aren't root, so don't bother checking the return value, this
> > +     * is just done as an optimistic privilege dropping function.
> > +     */
> > +    int saved_errno;
> > +    saved_errno = errno;
> > +    setgroups(0, NULL);
> > +    errno = saved_errno;
>
> Can be shortened to SAVE_ERRNO(setgroups(0, NULL)) but apart from that
> LGTM.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/joyent/libuv/pull/1105/files#r9593936>
> .
>