Add a whole-app-list unit test.

This establishes a test harness for doing tests that touch on multiple
parts of the app launcher UI, or that need coverage for the various app
launcher configurations: Ash or Desktop; regular or experimental
"landscape" mode.

It currently just tests displaying and closing the app launcher in its
default state with a flat (no folders), 2- or 3-page model.

BUG=169114
TEST=Added unit tests AppListViewTest{Aura,Desktop}.*

Review URL: https://codereview.chromium.org/210083009

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260762 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Revert of Add a whole-app-list unit test. (https://codereview.chromium.org/210083009/)

Reason for revert:
Broke Linux build.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/29124/steps/compile/logs/stdio

../../ui/app_list/views/app_list_view_unittest.cc:9:39: fatal error: base/strings/string_util.h.: No such file or directory


Original issue's description:
> Add a whole-app-list unit test.
> 
> This establishes a test harness for doing tests that touch on multiple
> parts of the app launcher UI, or that need coverage for the various app
> launcher configurations: Ash or Desktop; regular or experimental
> "landscape" mode.
> 
> It currently just tests displaying and closing the app launcher in its
> default state with a flat (no folders), 2- or 3-page model.
> 
> BUG=169114
> TEST=Added unit tests AppListViewTest{Aura,Desktop}.*
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260762

TBR=calamity@chromium.org,tapted@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=169114

Review URL: https://codereview.chromium.org/220323005

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260769 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Enable password API and scraping for SAML users on desktop

The CL refactors background.js to fully support multi-instance. As a side effect, it fixes crbug/349464

It also removes desktop_injected.js, since Gaia has implemented the same script on their side, the script will be enabled for all external users next Monday.

BUG=348002, 349464

Review URL: https://codereview.chromium.org/214533003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260777 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Update sync API to support attachments.

The purpose of this change is to start exposing attachment support in
the sync API. At this point there is no real functionality added.

SyncData and SyncChangeProcessor now know about attachments.

GenericChangeProcessor's ctor now requires an AttachmentService.

Add AttachmentService and FakeAttachmentService.

Update Attachment::Create* methods to return by value.

Make Attachment::CreateId public because it is useful in
sync_data_unittest.cc.

Make some ctors explicit.

BUG=348624

Review URL: https://codereview.chromium.org/187303006

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix DCHECK failure when reloading local_discovery_ui_handler code

Move code for adding signin listeners into block that isn't run on refresh,
since the LocalDiscoveryUIHandler object is not destroyed and recreated on
refresh but HandleStart is called.

BUG=

Review URL: https://codereview.chromium.org/218273003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Refactor ManagePasswordsBubbleView::GetMaximumFieldWidth.

We currently pass a 'bool' to determine whether we're looking
at the username or password fields. This CL changes that to
an explicit enum, and cleans up the calling code a bit for
clarity.

BUG=261628

Review URL: https://codereview.chromium.org/218993004

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260797 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Step 5 in unifying the task manager's WebContents-based ResourceProviders.

In this change, PrintingInformation, which plugs into
WebContentsResourceProvider, is introduced and the code that tracks
background printing pages is removed from TabContentsResourceProvider.

( WebContentsResourceProvider is introduced in an earlier patch:
https://codereview.chromium.org/196203003/ )

The new PrintingInformation tracks not only WebContents that are being
background printed, but also WebContents that are foreground print
preview dialog. Prior to this change these processes did not appear
in the task manager. Fixing this is what bug 345903 is about. A new
browsertest is added for this case.

BUG=348836, 345903
TEST=browser_tests including a new one

Review URL: https://codereview.chromium.org/201183005

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260801 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a whole-app-list unit test.

This establishes a test harness for doing tests that touch on multiple
parts of the app launcher UI, or that need coverage for the various app
launcher configurations: Ash or Desktop; regular or experimental
"landscape" mode.

It currently just tests displaying and closing the app launcher in its
default state with a flat (no folders), 2- or 3-page model.

BUG=169114
TEST=Added unit tests AppListViewTest{Aura,Desktop}.*

Previously committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260762

Review URL: https://codereview.chromium.org/210083009

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260803 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix the screen capture bubble background color.

Set the color after the widget has been initialized.
This gets the widget's correct native theme object.
Misc cleanup. See pics at http://crbug.com/351839#c1

BUG=351839
TEST=Screen capture bubble background is solid.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/220223002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260805 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Move reloading of focused frames to WebContents.

BUG=304341
TEST=no change

Review URL: https://codereview.chromium.org/213013003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260807 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[Hotword] Reset the hotword enabled preference to be disabled for those who had it previously set (either enabled or disabled). This means that folks who had it enabled will need to re-enable it. But anyone who might have had it enabled will no longer have it so.

This CL also removes the unneeded functions to deal with a pref change signal since that is now handled entirely by the HotwordService that enables/disables the extension itself.

Note: this code will probably be removed in M36. Tracking bug: crbug.com/358392

BUG=357845

Review URL: https://codereview.chromium.org/219573005

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260808 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a code path to open GAIA Add Account page from Print Preview.

BUG=139170

Review URL: https://codereview.chromium.org/217793003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260811 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add new strings for Print Preview multilogin UI.

BUG=139170

Review URL: https://codereview.chromium.org/220463002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260812 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix draggable regions on for frame:none app windows on views.

This was broken recently with a change that assumed the draggable
regions are static.

BUG=358071

Review URL: https://codereview.chromium.org/220363002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260813 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
StartupTimeBomb - Call DumpWithoutCrashing on WatchDog thread (instead
of UI thread).

jar fround in about:profiler, StartupTimeBomb::DeleteStartupWatchdog is
taking long time. We have found we are generating crash dump on UI
thread which could access disk and thus making UI thread janky.

R=jar@chromium.org

Review URL: https://codereview.chromium.org/214713009

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260814 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Prevent interaction with browser windows while a JS alert is visible.

BrowserView::CanActivate() ensures that a browser window cannot be activated for long while a JS alert is visible.
This CL prevents user interaction during the short time that the window is active. This hack is not necessary for Windows Aura

BUG=349970
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/216303002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260818 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add Easy Unlock setup app as a component app and expose it through about:flags.

BUG=347709

Review URL: https://codereview.chromium.org/205743003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260819 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a function to create a bookmark app from a WebApplicationInfo.

This CL adds a function which installs a bookmark app that is created
from a WebApplicationInfo. This is part of an effort to consolidate
code that deals with bookmark apps and write tests for them and is part of
laying the groundwork for syncing of bookmark apps.

BUG=318607

Review URL: https://codereview.chromium.org/202523011

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Revert of Rollback option for device reset put behind the flag. (https://codereview.chromium.org/212833004/)

Reason for revert:
Removing flag for M36.

Original issue's description:
> Rollback option for device reset put behind the flag.
> 
> BUG=356728
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259841

TBR=nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356728

Review URL: https://codereview.chromium.org/220863002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260824 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Revert of Add a whole-app-list unit test. (https://codereview.chromium.org/210083009/)

Reason for revert:
This patch broke 'sizes' by adding a static initializer. Seehttp://build.chromium.org/p/chromium/builders/Linux/builds/48686/steps/sizes/logs/stdio for the detailed dump.

Original issue's description:
> Add a whole-app-list unit test.
> 
> This establishes a test harness for doing tests that touch on multiple
> parts of the app launcher UI, or that need coverage for the various app
> launcher configurations: Ash or Desktop; regular or experimental
> "landscape" mode.
> 
> It currently just tests displaying and closing the app launcher in its
> default state with a flat (no folders), 2- or 3-page model.
> 
> BUG=169114
> TEST=Added unit tests AppListViewTest{Aura,Desktop}.*
> 
> Previously committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260762
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260803

TBR=calamity@chromium.org,tapted@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=169114

Review URL: https://codereview.chromium.org/220873002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@260826 4ff67af0-8c30-449e-8e8b-ad334ec8d88c