j.u.Date has all sorts of issues with it, not being threadsafe an mutable
by default can introduce lots of nasty serialisation bugs, that said it's
not a priority to improve right now.

Cheers,
Martijn


On 17 February 2014 19:35, Alex Theedom <notifications@github.com> wrote:

> In
> javacountdown-ee6/src/main/java/org/adoptopenjdk/javacountdown/entity/Visit.java:
>
> > -        return "Visit{" + "version=" + version + ", vMajor=" + vMajor + ", vMinor=" + vMinor + ", vPatch=" + vPatch + ", vBuild=" + vBuild + ", latitude=" + latitude + ", longitude=" + longitude + ", country=" + country + ", time=" + time + ", id=" + id + '}';
> > -    }
> > -
> > +	private static final long serialVersionUID = 1L;
> > +
> > +	@Id
> > +	private ObjectId id;
> > +	private int version;
> > +	private VersionInfo versionInfo;
> > +	private String country;
> > +	@Reference
> > +	private GeoPosition geoPosition;
> > +	private String browser;
> > +	private String os;
> > +	private Date time;
> > +
>
> In what way would it be safer? As time is not critical to the system and
> will only be used to produce time base reports/graphs (ie adoption of JDK 7
> by month) it might be OK as it is. Mongo doesn't hate me, not yet anyway!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AdoptOpenJDK/javacountdown/pull/67/files#r9802225>
> .
>