please update docstring + add a test