Nimisha/split converge api

Yeah, good point.


On Thu, Jul 17, 2014 at 2:01 PM, Don Mitchell <notifications@github.com>
wrote:

> In common/lib/xmodule/xmodule/modulestore/mongo/base.py:
>
> > @@ -1064,6 +1119,9 @@ def update_item(self, xblock, user_id, allow_not_found=False, force=False, isPub
> >          except ItemNotFoundError:
> >              if not allow_not_found:
> >                  raise
> > +            elif not self.has_course(xblock.location.course_key):
> > +                raise ItemNotFoundError
>
> Yes, it really should be that the course is not found. In this case, we
> don't care that the item wasn't found.
> … <#147457c941285678_>
> On Thu, Jul 17, 2014 at 1:46 PM, Calen Pennington <
> notifications@github.com> wrote: In
> common/lib/xmodule/xmodule/modulestore/mongo/base.py: > @@ -1064,6 +1119,9
> @@ def update_item(self, xblock, user_id, allow_not_found=False,
> force=False, isPub > except ItemNotFoundError: > if not allow_not_found: >
> raise > + elif not self.has_course(xblock.location.course_key): > + raise
> ItemNotFoundError Yeah. Or if we're indicating that the course wasn't
> found, it would be better to pass the course key to the ItemNotFoundError
> constructor. — Reply to this email directly or view it on GitHub <
> https://github.com/edx/edx-platform/pull/4381/files#r15072401>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/edx/edx-platform/pull/4381/files#r15073297>.
>