(PUP-3174) Make settings catalog skip manifestdir if environmentpath

This makes the settings catalog skip managment of manifestdir if
environmentpath is set.
Merge pull request #3055 from hlindberg/PUP-3177_Stable-Remove-square-bracket-magic-in-titles

(PUP-3177) Remove magic handling of square brackets in resource title
(PUP-1680) Set accept-encoding to identity when http_compression is false

Override the Ruby 2.x default of setting accept-encoding to gzip when puppet http_compression is set to false.
correct test description for http_compression disabled
Merge remote-tracking branch 'upstream/pr/3057' into stable

* upstream/pr/3057:
  correct test description for http_compression disabled
  (PUP-1680) Set accept-encoding to identity when http_compression is false

Closes GH-3057
(maint) Cleanup test to be more readable

The formatting was a little off, which made it hard to see what code was
in the test. This fixes the formatting and uses the resource matcher so
that it can provide a better error message.
Merge branch 'pr/3054' into stable

* pr/3054:
  (maint) Cleanup test to be more readable
  (PUP-3174) Make settings catalog skip manifestdir if environmentpath

Closes GH-3054
(PUP-3191) Fix symlink checking

Prior to this commit we were trying to use Pathname.realpath to find where a
symlink points to. This throws a file not found when the symlink doesn't point
at anything valid in the filesystem.
This commit fixes that problem by only using File.readlink and not attempting
to find the symlinked file relative to the module unpacking directory.
Merge pull request #3064 from highb/fix/master/symlink_check

(PUP-3191) Fix symlink checking
(PUP-3157) Allow variable DNS name order in helpful error cert name test

This commit updates the
`helpful_error_message_when_hostname_not_match_server_certificate.rb`
test to allow for the order in which the DNS names are enumerated back
from the master server's certificate to be variable.  This allows the
test to not errantly fail depending upon the order in which the names
were actually signed into the certificate.
(PUP-3151) Added acceptance test for External CA on Jetty

This commit adds an acceptance test which exercises External CA
functionality against a Jetty configuration.
(PUP-3151) Removed newline from host_entry test fixture

This commit removes the newline character from the end of the host_entry
method in the acceptance test ExternalCertFixtures.  The presence of this
character was causing the jetty_external_root_ca.rb test, when run on
Debian, to not properly set the needed hostname entry into the
/etc/hosts file.
Merge pull request #3067 from waynr/maint/stable/pup-3151

Add acceptance test for External CA on Jetty
Merge pull request #3066 from waynr/maint/stable/pup-3157

(PUP-3157) Allow variable DNS name order in helpful error cert name test
(PUP-3222) Rescue StandardError instead of non-existent exception

Previously, the windows service provider rescued exceptions of type
Win32::Service::Error. However, FFI-based versions of win32-service (v0.8.x)
no longer raise that type of error. Instead they raise SystemCallError.

So previously, if puppet failed to manage a service, e.g. service didn't
exist, puppet would try to rescue the exception specifying a class that
was not defined:

    puppet resource service foo ensure=stopped
    Error: /Service[foo]: Could not evaluate: uninitialized constant Win32::Service::Error

This regression was introduced as part of PUP-1283 when we migrated from
win32-service version 0.7.x to 0.8.x.

This commit modifies the various provider methods to more broadly rescue
StandardErrors and updates the spec tests to handle the negative cases.

Paired-with: Ethan J Brown <ethan@puppetlabs.com>
Merge pull request #3063 from joshcooper/ticket/stable/PUP-3222-sytemcallerror

(PUP-3222) Rescue StandardError instead of non-existent exception
wip