#555

Request to merge #555 into the master branch.
Chnaged.

On Mon, Dec 8, 2014 at 11:21 AM, Rachel Mandelbaum <notifications@github.com
> wrote:

> In galsim/detectors.py:
>
> > +
> > +    # Check for non-negativity of the kernel
> > +    if kernel_nonnegativity is True:
> > +        if (IPC_kernel<0).any() is True:
> > +            raise ValueError("IPC kernel must not contain negative entries")
> > +
> > +    # Check and enforce correct normalization for the kernel
> > +    if kernel_normalization is True:
> > +        if IPC_kernel.sum() != 1.0:
> > +            import warnings
> > +            warnings.warn("The entries in the kernel did not sum to 1. Scaling the kernel to "
> > +                "ensure correct normalization.")
> > +            IPC_kernel = IPC_kernel/IPC_kernel.sum()
> > +
> > +    # edge_treatment can be 'extend', 'wrap' or 'crop'
> > +    if edge_treatment is 'crop':
>
> Perhaps a minor point, but I think that strings should be compared for
> equality of value (using ==) rather than by object identity (using is).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GalSim-developers/GalSim/pull/615/files#r21463643>.
>



-- 
Regards

Arun Kannawadi Jayaraman
PhD candidate, Dept. of Physics,
Carnegie Mellon University,
Pittsburgh, PA 15213