Using strings for groups is not a big deal... Maybe if you're on an 8bit
microcontroller this matters but mixxx is not going to be ported to an 8088
anytime soon. ;)
On Feb 21, 2014 5:51 PM, "Daniel Schürmann" <notifications@github.com>
wrote:

> In src/effects/effectsmanager.cpp:
>
> > +    }
> > +    for (QHash<qint64, EffectsRequest*>::iterator it = m_activeRequests.begin();
> > +         it != m_activeRequests.end();) {
> > +        delete it.value();
> > +        it = m_activeRequests.erase(it);
> > +    }
> > +}
> > +
> > +void EffectsManager::addEffectsBackend(EffectsBackend* pBackend) {
> > +    Q_ASSERT(pBackend);
> > +    m_effectsBackends.append(pBackend);
> > +    connect(pBackend, SIGNAL(effectRegistered()),
> > +            this, SIGNAL(availableEffectsUpdated()));
> > +}
> > +
> > +void EffectsManager::registerGroup(const QString& group) {
>
> Is this registerEngine()?
>
> We should use the benefit, that we have a unique char* pointer for each
> Engine. I think we have accidentally broken this concept before, but it
> should be worth to repair it. A first step is change group to "const char*"
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/mixxxdj/mixxx/pull/180/files#r9965619>
> .
>