Ripple calc

* New uint160 tagged type NodeID.
* Categorize *all* non-generic instances of uint160 as Account, Currency or NodeID.
* Move conversions to and from strings to central .h file.
* Extract macro constants to be functions.
* Get rid of constructors and comparators between tagged uint types.
* New base_uint::copyFrom() allows explicit copying between any uint types
  of the same size.
* And lots of incidental cleaning and removal of unused code.
So I'm still not seeing what you're proposing.

We have this variable saBalance - which is an STAmount, which is basically
a currency, an issuer, and a quantity of money in that currency and issuer.
 A pre-condition for this call is that the issuer for the saBalance be
noAccount().  So what do you pass in instead of the STAmount?

Do note that if you just pass the issuer and quantity of money you
immediately would have to create another STAmount to pass forward again, as
far as I can see...




On Mon, Jun 23, 2014 at 11:16 AM, MarkusTeufelberger <
notifications@github.com> wrote:

> In src/ripple/module/app/ledger/LedgerEntrySet.cpp:
>
> >      uint256 const&  uIndex,             // --> ripple state entry
> >      SLE::ref        sleAccount,         // --> the account being set.
> >      const bool      bAuth,              // --> authorize account.
> >      const bool      bNoRipple,          // --> others cannot ripple through
> >      const STAmount& saBalance,          // --> balance of account being set.
> > -                                        // Issuer should be ACCOUNT_ONE
> > +                                        // Issuer should be noAccount()
>
> AFAIK "ACCOUT_ONE" (or now noAccount()) is used as a indication that there
> is not actual account necessary at this position, kinda like a "Null" value
> (https://ripple.com/wiki/Accounts#ACCOUNT_ONE). I'm proposing to leave it
> out entirely instead of reporting a base58 + checksum encoded 1
> (rrrrrrrrrrrrrrrrrrrrBZbvji) as a placeholder. Alternatively report
> something not-base58 encoded to make it clear this is not something that
> actually is expected to exist on the ledger (which makes this especially
> confusing since ACCOUT_ONE actually has been funded with XRP:
> https://ripple.com/graph/#rrrrrrrrrrrrrrrrrrrrBZbvji)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ripple/rippled/pull/410/files#r14080362>.
>



-- 
     /t

http://radio.swirly.com - art music radio 24/7 366/1000