utility to combine PaymentTransactionInfoPlugins

Maybe the pull request can be simplified to hide internal changes that aren't interesting after the fact
Probably you're right. We do have the message in the properties and in case
we have two that fail then user will need to go to properties anyway. I
worried that it might be misleading if we sometimes populate with the error.

-Kevin


On Fri, Aug 15, 2014 at 3:00 AM, Pierre-Alexandre Meyer <
notifications@github.com> wrote:

> In lib/killbill/helpers/utils.rb:
>
> > +          t1=t2
> > +          t2=nil
> > +        end
> > +
> > +        # Create the combined transaction info and set the values
> > +        t3=Killbill::Plugin::Model::PaymentTransactionInfoPlugin.new
> > +        t3.kb_payment_id=t1.kb_payment_id
> > +        t3.kb_transaction_payment_id=t1.kb_transaction_payment_id
> > +        t3.transaction_type=t1.transaction_type
> > +        t3.amount=t1.amount
> > +        t3.currency=t1.currency
> > +        t3.created_date=t1.created_date
> > +        t3.effective_date=t1.effective_date
> > +        t3.status=t1.status==:
> PROCESSED && ( t2.nil? || t2.status==:PROCESSED) ? :PROCESSED : :ERROR
> > +        t3.gateway_error=t1.gateway_error
> > +        t3.gateway_error_code=t1.gateway_error_code
>
> If t2 failed, but t1 succeeded, we probably want t2's message for the
> client.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/killbill/killbill-plugin-framework-ruby/pull/4/files#r16286389>
> .
>



-- 
Kevin Postlewaite