Do you  mind to add a unit test for this function?