Remove unused variables

o trove/backup/models.py:SWIFT_CONTAINER = CONF.backup_swift_container

  This variable was added in the following commit.

    commit ce208d6cabba227576f492e7647d9da5a89e7c25
    Author: ruiyuan-shen <ruiyuan.shen@hp.com>
    Date:   Mon Mar 18 14:07:37 2013 -0700

        Add snapshot ORM to reddwarf

  But there is no evidence that was used.

o trove/dns/rsdns/driver.py:DNS_HOSTNAME = CONF.dns_hostname

  This variable was added in the following commit.

    commit 0c34c75dc44876245709987a18ea004607fca815
    Author: Sudarshan Acharya <sudarshan.acharya@rackspace.com>
    Date:   Fri May 18 15:49:12 2012 -0500

        DNS Support for Instance IP.

  But there is no evidence that was used.

o trove/instance/models.py:SERVER_INVALID_ACTION_STATUSES
   = ["BUILD", "REBOOT", "REBUILD", "RESIZE"]

  This variable was removed in the following commit.

    commit 54a4ada785fd90af5134e7f38360938e0b435696
    Author: Ed Cranford <ed.cranford@rackspace.com>
    Date:   Thu Jul 12 15:01:01 2012 -0500

        Delete can now delete errored instances.

o trove/instance/models.py:VALID_ACTION_STATUSES = ["ACTIVE"]

  This variable was removed in the following commit.

    commit 9ccef6fea42454bb22c0d67bd4d2a0765f13d370
    Author: Tim Simpson <tim.simpson@rackspace.com>
    Date:   Wed Jun 27 11:12:28 2012 -0500

        Allowing resizes to be performed when MySQL is down.

Closes-Bug: #1286990
Change-Id: I79f5bb124f2702317d8d337c969c9ff8ea69a769
Change Cassandra to Service Start vs Bin

starts cassandra with 'sudo service cassandra start' vs.
'sudo /usr/sbin/cassandra' to avoid having cassandra stopped if the
guestagent is stopped. see the bug details for more information.

Change-Id: Ifab557aaff5023f4b0fb4b91193785a0deb5ee2f
Closes-Bug: #1295313
Pop instead of get for timeout kwarg

In utils.py execute_with_timeout() method was updated
to do kwargs.pop() instead of kwargs.get()

Closes-Bug: #1292692
Change-Id: Id69e66f5e312a2bd2501bae18ddd050dd4296ff5
Tox tests should not require errors in rigid order

Fix the tox tests to not require Validation Error messages to be returned
in a specific order. Since the order of validation errors can be
non-deterministic, the tests should merely check for existence of the error.

Change-Id: I615359cfb7129b2af9f22c43ad4475b53f7acab3
Closes-bug: 1294850
Remove mockito, and replace with mock

There are unit tests in trove which are dependent on mockito.
This fixes them to use the standard mock library which is a part
of global_requirements.

Co-Authored-By: Justin Hopper <justin.hopper@hp.com>
Implements-bp: remove-mockito
Change-Id: Ic030cc846d9e7d0c9077240b0fac90f4f66a5a42
Updated from global requirements

Change-Id: Ie9d3fc8dd87474814c4684998f8003e7a216e9d9
Fix create call for security group rules

We need to fix the create security group call to
correctly use the per-datastore configs to set the
port, and protocol values for the security group rule.

The only parameter that the trove user should be able to
specify for the rule is the CIDR.

Changes:
- Use the datastore specific ports and protocol for creating
  the new security group rule.

Changes:
- using datastore-specific ports for building new rules, based upon income CIDR;

Change-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6
Closes-Bug: #1298749
Fixed unit test to not actually run backup command

One unit tests is still trying to execute the actual backup command
instead of the mocked backup command. This is causing an issue on
the Jenkins slave where it is trying to run as sudo (and failing).
Fixed the test to use a mock runner, and not try to run innobackupex.

This had been previously fixed by commit 19d940516e, but that fix was
clobbered by the move from mockito to mock.

Change-Id: Ib63187d4414a3ef7b7f664e076bb4d92a40c2214
Closes-bug: 1291516
Merge "Updated from global requirements"
Open Juno development

Bump preversion to 2014.2 to formally open Juno development.
The Icehouse release branch (milestone-proposed) will be cut
from the last commit before this one.

Change-Id: If15dd3aa2b9470570d3d9afaf3551618f41ebb97
Merge "Fix create call for security group rules"
Merge "Open Juno development"
Changed assert statement of test_volume_found

Reason:test_volume_found is failing for datastore other than msql
       As volume used for cassandra and others is less than
       threshold defined in test

Change:Changed the threshold check for used volume

Change-Id: Idcf29e8dc924f192fc96682eff05878e274df7ab
Closes-Bug: #1301826
Merge "Change Cassandra to Service Start vs Bin"
Merge "Changed assert statement of test_volume_found"
Merge "Remove unused variables"
Merge "Pop instead of get for timeout kwarg"