Is debugging useful to "normal" users or only kernel hackers? If you think that someone would need to turn on debug so that we can help them troubleshoot a problem, then this is OK, otherwise I would used #defines to enable the debug. There are many examples in other drivers on how to do this.