Rewrite raw memcard threading code. Intended to fix issue 7484.

Its not really my place to say anything but switching tabs to spaces
inflates the code size. By like... A lot. It has the chance of inflating
them by around 2-3 times it's size. I'd rather not have to waste time
attempting  to pull a commit that would take me possibly hours to download
just because someone felt it was necessary to change all tabs into spaces.
(This is all my personal opinion, please don't kill me about this)
On Aug 11, 2014 2:16 AM, "Pierre Bourdon" <notifications@github.com> wrote:

> In Source/Core/Core/HW/GCMemcardDirectory.h:
>
> > @@ -13,15 +13,17 @@ void MigrateFromMemcardFile(std::string strDirectoryName, int card_index);
> >  class GCMemcardDirectory : public MemoryCardBase, NonCopyable
> >  {
> >  public:
> > -	GCMemcardDirectory(std::string directory, int slot = 0, u16 sizeMb = MemCard2043Mb, bool ascii = true,
> > -		DiscIO::IVolume::ECountry  card_region = DiscIO::IVolume::COUNTRY_EUROPE, int gameId = 0);
> > -	~GCMemcardDirectory() { Flush(true); }
> > -	void Flush(bool exiting = false) override;
> > +	GCMemcardDirectory(std::string directory, int slot = 0,
> > +					   u16 sizeMb = MemCard2043Mb, bool ascii = true,
>
> I do, I'm just saying that if it ever existed (I don't remember anything
> like that, but again I wasn't working on the project before 2012-ish), this
> policy was strongly misled. I find this as stupid as you do and I'm just
> waiting for enough people to be annoyed by it and switch to spaces
> indentation in the whole project.
> … <#147c3b6118798d68_>
> On Sun, Aug 10, 2014 at 11:14 PM, shuffle2 <notifications@github.com>
> wrote: In Source/Core/Core/HW/GCMemcardDirectory.h: > @@ -13,15 +13,17 @@
> void MigrateFromMemcardFile(std::string strDirectoryName, int card_index);
> > class GCMemcardDirectory : public MemoryCardBase, NonCopyable > { >
> public: > - GCMemcardDirectory(std::string directory, int slot = 0, u16
> sizeMb = MemCard2043Mb, bool ascii = true, > - DiscIO::IVolume::ECountry
> card_region = DiscIO::IVolume::COUNTRY_EUROPE, int gameId = 0); > -
> ~GCMemcardDirectory() { Flush(true); } > - void Flush(bool exiting = false)
> override; > + GCMemcardDirectory(std::string directory, int slot = 0, > +
> u16 sizeMb = MemCard2043Mb, bool ascii = true, I am reasonably sure you
> understand my point. — Reply to this email directly or view it on GitHub <
> https://github.com/dolphin-emu/dolphin/pull/778/files#r16038582>.
>  -- Pierre "delroth" Bourdon <delroth@gmail.com> Software Engineer @
> Zürich, Switzerland http://code.delroth.net/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dolphin-emu/dolphin/pull/778/files#r16038624>.
>