Dell - Internal Use - Confidential
+1.  Thanks

From: Victor Lowther [mailto:notifications@github.com]
Sent: Sunday, March 16, 2014 7:49 AM
To: opencrowbar/core
Cc: Hirschfeld, Rob
Subject: Re: [core] Goodbye, Snapshots. (#79)


In rails/app/controllers/barclamp_controller.rb:

> -# limitations under the License.

> -#

> -require 'json'

> -

> -class BarclampController < ApplicationController

> -

> -  self.help_contents = Array.new(superclass.help_contents)

> -

> -  #

> -  # Barclamp List (generic)

> -  #

> -  # Provides the restful api call for

> -  # List Barclamps  /crowbar       GET     Returns a json list of string names for barclamps

> -  #

> -  add_help(:index)

> -  def index

The code in barclamps_controller is, and having both barclamp_controller and barclamps_controller is just insane code duplication.

—
Reply to this email directly or view it on GitHub<https://github.com/opencrowbar/core/pull/79/files#r10639410>.