changes to add attributes