CR for Job #20142 - Walk Cycle Polish Description

Code Review for Job #20142 - Workitem available at https://www.worklist.net/20142
Hi Brad,

All points raised are now fixed.

I note you didn't mention the tabs in walk.js - just in case you've not
gone through that file yet and didn't see my comment on the first commit:

walk.js is now under 100,000 characters, but I had to use tabs instead
of 4 spaces to get it below the threshold.


Please note that I plan to put most of the animateAvatar function into one
big loop after the 'turn on the spot' animation has been in implemented in
a later iteration. But for now, I find it far easier to deal with editing
the intricacies of the sine wave generators with them all 'laid open'. I
hope that's OK!

Cheers,

 - Dave

On 10 November 2014 22:21, Brad Hefta-Gaub <notifications@github.com> wrote:

> In examples/libraries/walkInterface.js:
>
> > +                Overlays.editOverlay(_femaleBigButtonSelected, {
> > +                    visible: false
> > +                });
> > +                Overlays.editOverlay(_maleBigButtonSelected, {
> > +                    visible: true
> > +                });
> > +                Overlays.editOverlay(_maleBigButton, {
> > +                    visible: false
> > +                });
> > +                return;
> > +
> > +            case _armsFreeBigButton:
> > +
> > +                _motion.armsFree = true;
> > +
> > +                Over
>
> spacing is off here... looks like tabs instead of spaces -- for all the
> else statements in this if statement
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/highfidelity/hifi/pull/3760/files#r20118054>.
>