TODO for attributes