Oh, that got in too soon perhaps, although no harm would be to leave it.
I'm actually working to make this module to support volatile db, i.e. that
database server can go off and come back any time. I'll have it tomorrow
hopefully.
On Feb 2, 2014 10:09 PM, "Frank Smit" <notifications@github.com> wrote:

> In momoko/connection.py:
>
> >          def multi_callback(connection, error):
> >              if error:
> > -                raise error
> > +                if raise_connect_errors:
> > +                    raise error
> > +                else:
> > +                    log.error("Failed opening connection to database: %s", error)
> > +            self._pool.append(connection)
>
> Should the connection be added to the pool after it failed connecting to
> the database?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/FSX/momoko/pull/59/files#r9371593>
> .
>