Again, I'm sorry I was out of line. I have a tendency to think and speak
impulsively and that often works fine but sometimes gets me into trouble. I
will try to remember to be better about this, and I will accept whatever
responsibility Grigore feels appropriate to ensure we have a good culture
of communication and code quality, even if it means being disciplined
myself.

That said, I will now update the Code Reviews page on the wiki to make the
foundational principles above clear. These are vital and non-negotiable
priorities:

1. Changes to make code cleaner which take only a couple days' extra work
should be done prior to code being pushed upstream.
2. Users must be willing to modify whatever classes are necessary in order
to cleanly commit their own changes.

The constructors which take varargs are literally one line each. Also, a
single concept may require many statements if it is composed of pieces
distinct in meaning. E.g. a term and a set.

Make it so.
On Mar 12, 2014 5:01 PM, "Grigore Rosu" <notifications@github.com> wrote:

> In src/javasources/KTool/src/org/kframework/parser/concrete2/Grammar.java:
>
> >              if (this instanceof ExitState) {
> > -                return new HashSet<KList>(Arrays.asList(new KList(Arrays.asList((Term)new Ambiguity("K", new ArrayList<Term>(input))))));
> > +                return new HashSet<KList>(Arrays.asList(new KList(Arrays.asList((Term)new Ambiguity("K", new ArrayList<Term>(result))))));
>
> Code quality is not negotiable in this project anymore, and Dwight is
> explicitly in charge of it. We should all make an effort to be disciplined
> in order for this to work out well. That means on the one hand that Dwight
> should be less sarcastic and focus on the actual issue and propose the best
> solution in his opinion, and on the other hand that we, the others, should
> not oppose minor or stylistic requested changes to our code only because we
> can and want to. Neither of these is constructive. The code in this project
> belongs to the "K Team" and we want it to look good, as if written by one,
> excellent programmer. This will make our own life, before anybody's else,
> easier in the long term.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/282/files#r10543573>
> .
>