(PUP-2987) Windows service runinterval parsing

 - Refactor parsing code to a separate method to cleanup run loop
(maint) Move methods for creating downloaders to factory

Previously, the plugin_handler module was responsible for creating
downloaders and evaluating them. Since all of this happens within a
single method it is hard to test that the downloaders are created with
the correct set of properties. For example, we `ignore` source
permissions when downloading plugins, but we `use` source permissions
when downloading external facts, since those often contain scripts,
which must be executable.

This commit moves the logic for creating the downloaders to a factory
and updates the tests accordingly. As part of this change, the
PluginHandler module is changed to a class and is no longer mixed into
the Configurer.
(maint) Test that external fact syncing depends on external feature

Previously, the test was trying to verify that the downloader objects
were created with the correct arguments, and testing that the
downloader was evaluated twice (since the same downloader was used for
both pluginsync and facts).

However, the downloader_factory_spec now tests that downloader objects
are created correctly, e.g. based on Puppet[:plugindest], so it is not
necessary to repeat that here.

This commit modifies the test to ensure the Downloader#evaluate
methods are called for both downloader objects, and adds a test to
ensure we skip downloading facts if the external facts feature is
false.
(PUP-1527) After upgrade from 3.3.2-1 to 3.4.2-1 naginator fails to
create config from exported resources taken from hiera

Some changes introduced in hiera around 3.4 resulted in type coersion
from strings to FixNums when creating exported resources that were
partially built from hiera data.

This patch ensures that any non-array parameter passed through the
Nagios::Base.to_s is actually a string before trying to run the .sub
method on it, and so fixes the above error with exported resources
whilst also introducing support for fixnum params for any of the nagios
type parameters
(docs) Clarify possible exit codes and behavior with negative exit codes on Windows
(PUP-2972) Remove += and -=

Previously the future parser supported += and -=. += was very similar to
the same operator that is in the current parser, but with a few
differences to make it consistent with the rest of the
language. The += operator no longer performed string concatenation and
instead acted like $a = $a + $b. The -= operator was added to complete
the set of operators available.

However, many people have been confused by these operators (even as they
exist in the current parser):

  * It looks like mutation, but the language does not have mutation
  * It looks like += from other languages, but doesn't behave like them
  * Shadowing a variable is something that needs to be explicit,
    otherwise it becomes confusing.

This removes += and -= from the future parser. They are still parsed,
but the validation step will issue errors if they are encountered.
(docs) Remove stale warning that Windows can't manage symlinks

Windows can manage symlinks, and we explain the limitations (extra permissions
needed, no-go on 2003) in the `ensure` attribute.
(PUP-2879) Add two nfsd-related upstart services to the blacklist
(PUP-2972) Improve error message for += and -=

The previous error message was very abrupt and didn't provide any kind
of guidance for the user. The new message for += and -= let's them know
that it is *no longer* supported and has a link to where they can get
more information.
Merge pull request #2958 from zaphod42/issue/master/pup-2972-remove-plussignment

(PUP-2972) Remove += and -=
Merge pull request #2959 from nfagerlund/docs_windows_symlink_straggler

(docs) Remove stale warning that Windows can't manage symlinks
Merge pull request #2960 from kylog/issue/pup-2879/add-more-services-to-blacklist

(PUP-2879) Add two nfsd-related upstart services to the blacklist
Merge pull request #2879 from nfagerlund/docs_exec_exitcodes_windows

(docs) Clarify possible exit codes and behavior with negative exit codes on Windows
(PUP-3050) Update cfacter option for recent cfacter gem changes.

Now that cfacter implements the Ruby Facter interoperability layer, there
is no need for Puppet to "switch out" the Facter module for the CFacter
module.  libfacter itself will now expose a compatible Facter module in
C++.

Therefore, we no longer need facts.rb or the corresponding spec.
Instead, simply require cfacter and call CFacter.initialize.  This will
replace Ruby Facter with the libfacter implementation.
(PUP-3056) Restore Windows constants from mixins

 - Previously these constants were defined by using mixins from
   windows-pr.  As it turns out, while Puppet core does not need them,
   they are consumed by the ACL module.
(PUP-417) Make use of QENG-188 to restart puppet in acceptance

Versions of Beaker prior to the patch in QENG-188 relied on manually
starting and stopping puppet with a `puppet master *args` commandline
invocation followed by a `kill $puppet_pid`. To better mirror manual
smoke testing, we want to be able to start and stop puppet using the
service scripts provided by the installation packages, using `puppet
resource service` calls. We also want to be able to test Puppet from
packages that install with Passenger, relying on an apache restart.

These changes are all in Beaker, in QENG-188, but this commit is needed
to adjust puppet acceptance's setup steps to differentiate between a git
installation, a foss package installation, and a foss package
installation with passenger. Several tests were adjusted as well to be
agnostic between foss webrick/passenger installations, wherever
possible.

This commit also pins to Beaker ~> 1.17, which will pick up future
versions of Beaker < 2.0.  Beaker is smoke testing PRs against Puppet
acceptance, among other projects, so I think it's safe to stay
abreast of releases in the 1.y series.
Merge pull request #2871 from jpartlow/issue/master/pup-417-passenger-acceptance

(PUP-417) Make use of QENG-188 to restart puppet
(PUP-2907) Ignore source permissions on windows for fact sync

Previously, puppet on windows would always issue a warning:

    Copying owner/mode/group from the source file on Windows is
    deprecated; use source_permissions => ignore

Regardless of what was in the user's catalog. The reason is because
puppet applies an internal catalog to download external facts, and that
catalog contains a file resource whose source_permissions parameter is
set to `:use`.

This is done because external facts are often times scripts, which must
be executable for puppet to invoke them. See commit 21edcd67b for
PUP-2705.

This commit makes it so that source permissions for external facts are
ignored on Windows, while preserving existing behavior on other
platforms.

Permissions can be ignored on Windows, because puppet always has full
control of files it creates.
Merge pull request #2970 from kylog/joshcooper-ticket/master/PUP-2907

ticket/master/pup 2907
(PUP-2631) Elide long URIs for 404 message

When the agent encounters a 404 response from the master and it has been
told to fail on 404, it previously output the entire path plus query
string that it requested. However, the most common case where this
occurs is when requesting a catalog, which can have a very long query
string if the request was done with a GET. This does not always occur
because even longer query strings will result in the agent using a POST
instead of a GET, which causes the long query string output problem to
go away.

In order to fix this the query string is now elided to 100 characters
(97 characters of the original text plus 3 periods).  In order to still
be able to debug any problems that might result from the query, however,
the query string is *not* elided if the log level is `debug`.