I agree with both of you guys in principle...for this code, though, it's more what Taylor is describing than what Reid is describibg (e.g. the numbers tend to mean "empty" or "has one" or "has 2") and it's fairly well commented in most cases as to what they mean.  In other cases, where we're pulling out a specific position or a specific ID, variables or constants are definitely the way to go.  It would also be worth someone taking a look at all of our tests, and pulling out common patterns that we can make clearer, which should help us write more, better tests in the future.  Maybe that can be an action that we attach to our automated testing work?