What about not letting `left` be greater than `right`?


On 1 April 2014 16:40, vidartf <notifications@github.com> wrote:

> In hyperspy/gui/egerton_quantification.py:
>
> > @@ -343,7 +343,11 @@ def _interpolator_kind_changed(self, old, new):
> >          self.span_selector_changed()
> >
> >      def _ss_left_value_changed(self, old, new):
> > -        self.span_selector_changed()
> > +        try:
> > +            self.span_selector_changed()
> > +        except ValueError:
> > +            if self.ss_right_value != NaN:
>
> Not completely steady on python NaN handling. Changed to use np.NaN
> everywhere, and realized I forgot to update background removal version:
> https://github.com/vidartf/hyperspy/commit/176d2f51aa5851ef563e92fd0c47c6280ad4eeccMaybe the best overall option is to allow left and right to be
> interchangeable (left is minimum value, etc.)
> ... <#1451df333b0aeaf7_>
> On Tue, Apr 1, 2014 at 5:18 PM, francisco-dlp <notifications@github.com>wrote:
> In hyperspy/gui/egerton_quantification.py: > @@ -343,7 +343,11 @@ def
> _interpolator_kind_changed(self, old, new): > self.span_selector_changed()
> > > def _ss_left_value_changed(self, old, new): > -
> self.span_selector_changed() > + try: > + self.span_selector_changed() > +
> except ValueError: > + if self.ss_right_value != NaN: Shouldn't NaN be
> np.nan instead? -- Reply to this email directly or view it on GitHub<
> https://github.com/hyperspy/hyperspy/pull/258/files#r11164877> .
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/hyperspy/hyperspy/pull/258/files#r11165932>
> .
>