ceph::key : remove the client.admin keyring for tests

To avoid unintended side effects between integration tests.

Change-Id: I3f084244291d4608b9090ecaad915f5543430d1d
Signed-off-by: Loic Dachary <loic@dachary.org>
ceph::key : reduce literal duplication in tests

Set keys in variables instead of duplicating them in the tests to avoid
spelling mistakes.

Change-Id: Iebbab700da62e8c99869a5cb5fd1ee1730318979
Signed-off-by: Loic Dachary <loic@dachary.org>
ceph::key : proofread documentation strings

Change-Id: Ice6c57375a6ba28e134fa8c9bb87fa55b6974fc1
Signed-off-by: Loic Dachary <loic@dachary.org>
update the first use case to reflect that it works

The first use case works with the current implementation. It is updated
to remove the warning and the syntax is adapted to match the
reality. Instead of a laptop, it is suggested that the test is done on a
virtual machine because it is much more likely.

Change-Id: I7fafb2a6d06eb146b6a2407fb20fdfc4846889f9
Signed-off-by: Loic Dachary <loic@dachary.org>
ceph::mon : remove useless comments from tests

Change-Id: I2cc5c3a1d2e3d130fb66f4a8adcd00786434391c
Signed-off-by: Loic Dachary <loic@dachary.org>
ceph::mon : tag cephx spec test

And add a comment to be interpreted by emacs and used as a reminder at
the end of the mon test file.

Change-Id: I665b233d89de964db9f84c308ab31beba1bb7fba
Signed-off-by: Loic Dachary <loic@dachary.org>
ceph::mon : control client.admin key generation

Creating an empty /etc/ceph/ceph.client.admin.keyring file disables the
automatic creation of the client.admin credentials when the first
monitor is created.

The creation of the key must be done via ceph::key, using the
mon. keyring, in the same way ceph-create-keys does.

Modify the client.volumes test to actually use cephx instead of
injecting a key in a non cephx cluster. It makes the client.something
test redundant and also demonstrates that the client.admin key can be
created by puppet instead of being automatically created by
ceph-create-keys.

Change-Id: I7060e418c27ea3f6f4e53604044f21865438382e
Signed-off-by: Loic Dachary <loic@dachary.org>