What are you doing later tonight? :)


On Sat, Jan 25, 2014 at 4:40 PM, jdungan <notifications@github.com> wrote:

> In data/launch.js:
>
> > +      .done(function(data) {
> > +        console.log("$.ajax successful.");
> > +        var codesyToken = data.csrf_token;
> > +        console.log(data);
> > +        if($(mission.target.selector).length >0 ){
> > +
> > +          console.log("getting codesyImgUrl");
> > +          var codesyImgUrl = self.options.codesyImgUrl;
> > +          console.log("codesyImgUrl: "+codesyImgUrl);
> > +          codesy.options.domain = self.options.codesyDomain;
> > +          console.log("domain: "+codesy.options.domain);
> > +
> > +          mission.before_append && mission.before_append (self.options);
> > +
> > +
> > +          codesy.appendForm(mission, codesyImgUrl, codesyToken)
>
> $,ajax is a deferred object so you can't avoid it. Why do you merge it and
> let me take a crack at it. Or let's get together and walk through the code.
> ... <#143cb8fd8576893f_>
>  On Jan 25, 2014, at 4:28 PM, luke crouch <notifications@github.com>
> wrote: In data/launch.js: > + .done(function(data) { > +
> console.log("$.ajax successful."); > + var codesyToken = data.csrf_token; >
> + console.log(data); > + if($(mission.target.selector).length >0 ){ > + > +
> console.log("getting codesyImgUrl"); > + var codesyImgUrl =
> self.options.codesyImgUrl; > + console.log("codesyImgUrl: "+codesyImgUrl);
> > + codesy.options.domain = self.options.codesyDomain; > +
> console.log("domain: "+codesy.options.domain); > + > +
> mission.before_append && mission.before_append (self.options); > + > + > +
> codesy.appendForm(mission, codesyImgUrl, codesyToken) Removing it didn't
> change anything. I'm leaning towards taking these deferred/promises out. I
> think they may not work with the way Firefox content scripts communicate
> with other js modules in the add-on. -- Reply to this email directly or view
> it on GitHub.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/codesy/firefox-addon/pull/14/files#r9173370>
> .
>