refactoring attribute