What's wrong with PHP_EOL? By using it we don't have to worry about asking
ourselves what we need to use.

On Saturday, March 15, 2014, Weston Ruter <notifications@github.com> wrote:

> In includes/settings.php:
>
> > @@ -124,8 +121,19 @@ public static function get_users(){
> >  			}
> >
> >  			$args = array(
> > -				'id'   => $user->ID,
> > -				'text' => $user->display_name,
> > +				'id'       => $user->ID,
> > +				'text'     => $user->display_name,
> > +			);
> > +
> > +			$args['tooltip'] = esc_attr(
> > +				sprintf(
> > +					'%s%5$s%s%5$s%s%5$s%s',
> > +					__( 'ID:', 'stream' ) . ' ' . $user->ID,
> > +					__( 'User:', 'stream' ) . ' ' . $user->user_login,
> > +					__( 'Email:', 'stream' ) . ' ' . $user->user_email,
> > +					__( 'Role:', 'stream' ) . ' ' . implode( ',', self::get_roles() ),
>
> I don't think PHP_EOL will make much difference here, since it would only
> matter (even slightly) for server-side processing of the textual data. But
> this is getting output straight to the client. So the question is, in JS do
> browsers like \n or \r\n more?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/x-team/wp-stream/pull/340/files#r10638244>
> .
>


-- 
*Jonathan Bardo*
Web Developer
[image: X-Team] <http://x-team.com/>