CID# 30256, 30238 deref after null check and dead code in dbus_server.c

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID# 30343 out of bounds access in client_mgr.c

gsh_calloc args were swapped...

Signed-off-by: Jim Lieb <jlieb@panasas.com>
Replace fixed sized hostaddr_str in gsh_client with gsh_strdup'd string

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30396 Uninitialized value in decode_acl

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#56785 resource leak in nfs_rpc_create_chan_v40

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30215, 55618 Add NULL term to *list_ext_xattrs

This whole thing needs to be rewritten to support something like callbacks
and get rid of these fixed size arrays etc. 9p_xattrwalk.c seems to be the
only protocol level user of this FSAL method.

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30376 Fix NULL dereference in nfs_rpc_callback free_single_call

Get the NULL tests in the right order

Signed-off-by: Jim Lieb <jlieb@panasas.com>
Fixed Gluster include path when setting GLUSTER_PREFIX

If Gluster include files aren't at the usual location, manually setting
GLUSTER_PREFIX parameter with cmake wasn't properly handled.
Signed-off-by: Thomas Favre-Bulle <thomas.favre-bulle@bull.net>
CID# 30389 Insecure data handling in _9p_socket_thread

- Convert pointer in to buffer to a scalar to remove indirect ref

- test length for correct bounds

- Tighten up 9P message loop.

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30372 Resource leak in mnt_Export

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30345, 30346  Wrong sizeof for memcmp in sockaddr_cmpf

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#59784 Control flow (dead code) and leaked resources

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#55638, Dead code in ZFS xattrs.c

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#55629 Unsigned >= 0 compare

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#55635 uninit'd scalar

object is used to set an unused var that has been hanging around
for a long time. Just get rid of i_snap completely.

exit on ENOENT error rather than just falling thru to madness.

Signed-off-by: Jim Lieb <jlieb@panasas.com>

squash CID#55635

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#55621 Dead code removal ZFS xattrs.c

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30336,30335 Unsigned compare < 0

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30400 Dead code removal VFS xattrs.c

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30380 Dereference before NULL check in gss_credcache.c

Signed-off-by: Jim Lieb <jlieb@panasas.com>
CID#30352 Printf arg type mismatch

Also change to use abstract_atomic.h

Signed-off-by: Jim Lieb <jlieb@panasas.com>