References and pointers. I also don't see the point for parameters passed
by value.


On Sun, May 25, 2014 at 10:06 PM, comex <notifications@github.com> wrote:

> In Contributing.md:
>
> > +- When declaring includes in a source file, make sure they follow the given pattern:
> > +  - Standard library headers
> > +  - System-specific headers (these should also likely be in an `#ifdef` block unless the source file itself is system-specific).
> > +  - Dolphin source file headers
> > +- Each of the above header sections should also be in alphabetical order
> > +- Project source file headers should be included in a way that is relative to the `[Dolphin Root]/Source/Core` directory.
> > +- This project uses `#pragma once` as header guards.
> > +
> > +### Loops
> > +- If an infinite loop is required, do not use `for (;;)`, use `while (true)`.
> > +- Empty-bodied loops should use braces after their header, not a semicolon.
> > +  - Yes: `while (condition) {}`
> > +  - No: `while (condition);`
> > +
> > +### Functions
> > +- If a function parameter is not intended to have their assigned value or data changed, please mark that parameter as `const`. Local variables within functions that do not change value should also be marked accordingly as well.
>
> Reference parameters or just random value parameters? I don't think I've
> seen the latter done in any codebase except Dolphin.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dolphin-emu/dolphin/pull/410/files#r13032580>
> .
>



-- 
Pierre "delroth" Bourdon <delroth@gmail.com>
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/