Not in these cases. Puppet 3.1.0 is not very reliable in passing tests (I've got modules that pass everything except 3.1.0), and your own code does not yet pass STRICT_VARIABLES. I'm not second guessing your intentions setting that.

However the code passes without it, so this lets us see if the code is good without that flag.

Mostly I wanted to see the tests pass, to be sure the module was usable.