* Notify ACL change only if an ace has changed or action has changed
  Test case for same

Change-Id: I9351c504efeb76c676ac453ddefabb41f1095fc2
Delete vrouter reference on VM deletion

For source-nat service instance, virtual machines composed the service
instance have a back ref on a vrouter. Delete the reference on that
vrouter before deleting the virtual machine.

Change-Id: I697583dbf54662b98f50648ec506123424a6c3ab
Signed-off-by: Édouard Thuleau <edouard.thuleau@cloudwatt.com>
[Schema transformer] Retrun a correct set from VirtualNetworkST.delete

The methode VirtualNetworkST shoud always return a set() event if the
virtual network was already deleted.

Change-Id: Ib34bc255c3e63e70ecfa8e8c73f2786c60bd3845
Signed-off-by: Édouard Thuleau <edouard.thuleau@cloudwatt.com>
Bug 1332906: vm ref may not be present in vmi. Ignore if this happens

Change-Id: I786b437568b61fbad01894e822ccd69b6ef99751
Fix bug in XmppChannel close that causes an assert to fail later.

https://bugs.launchpad.net/juniperopenstack/+bug/1332779

If the vrf_membership_request_map_ is non-empty when XmppChannel
close is started, but the routingtable_membership_request_map_ is
empty, the close of the XmppPeer is not deferred.  If a routing
instance that's in the vrf_membership_request_map_ subsequently
gets created before the XmppPeer close process is complete, one
or more RTarget routes for the routing instance are published and
registration for the tables in the instance is triggered. These
routes cause an assertion to fail when the XmppPeer is destroyed.

Following changes are implemented to address this problem.

- Clear vrf_membership_request_map_ when XmppChannel close starts
- Ignore RoutingInstance callback if XmppChannel is closing
- Do not add a RTarget route if XmppChannel is closing
- Flush the defer_q_ on XmppChannel close

Make refcount_ in BgpPeer/XmppPeer mutable to avoid const_cast.
Add assertion that a BgpPath from a down peer cannot be inserted.
Do not replicate BgpPaths from a down peer.
Rename defer_close_ to defer_peer_close_ to clarify it's purpose.

Add tests to bgp_xmpp_deferq_test.cc for scenario in question.
Make TearDown more robust by waiting for queues to be empty.

Change-Id: I052f2335c77cf13fc219fa21955104b251ab97f1
Merge "[Schema transformer] Retrun a correct set from VirtualNetworkST.delete"
Merge "Fix bug in XmppChannel close that causes an assert to fail later."
Merge "* Notify ACL change only if an ace has changed or action has changed   Test case for same"
Merge "Bug 1332906: vm ref may not be present in vmi. Ignore if this happens"
Revert "Add a pool of workers for the method walk"

This reverts commit e57b6409f4eaf8ea2571d5ae5c66c04c39326a94.

Change-Id: I81a94d602c7a099032b07e4ab3588dedfb0067ff
Revert "Avoid unecessary call to cassandra when using walk."

This reverts commit 9591265d2c81144e767ce9ccf2c5cdd2d9ab98f8.

Change-Id: I7e706aea174dda64b973f1deff309417e826959e
Add connection_info to control-node which signals the status of connection to ifmap (irond) server, discovery server and collector server

Change-Id: I0988b3290e087c9659ec4cd916718aa016352f29
Move rtarget_table_test to controller/src/bgp/rtarget:flaky-test

Change-Id: Iff5ec3a383567e6d5523b2fad8e61d59b5d424bf
Neutron Compatability:
- added right bottle error codes for failures
- added validation functions needed for tempest tests
- net-list will now return subnet-id list instead of subnet-dict

Change-Id: Iaa7d61521f1a1e51e732af0b1d86d5a0e1569768
Merge "Delete vrouter reference on VM deletion"
Merge "Revert "Add a pool of workers for the method walk""
Merge "Revert "Avoid unecessary call to cassandra when using walk.""
Merge "Add connection_info to control-node which signals the status of connection to ifmap (irond) server, discovery server and collector server"
Merge "Neutron Compatability: - added right bottle error codes for failures - added validation functions needed for tempest tests - net-list will now return subnet-id list instead of subnet-dict"
Fix issues in bgp_config_listener_test.cc.

Change-Id: I1e3a3818b3b52fc45e7aa6a2b1358f33cb9f6550