[RFC] Subtitle cycle

Next ;) This replaces #4931 which in turn replaces #4030.

>
This is a RFC for http://forum.xbmc.org/showthread.php?tid=183437 so to get a bit more eyes on the namings etc.
>
Some considerations
1) This is very quickly thrown together and I will test it more before final PR
2) This PR does not include keymaps being changed (as they should most likely have CycleSubtitle)
3) Should we perhaps quick return when only one subtitle is available.
>
As an extention to 3) we should perhaps add so skins can hide the "Next subtitle" button when its only one available?

The point is that its a separate action. As cycle is good for skins if you
have a enable button but next (with disable) makes sense for remotes or
skins wishing not to have the enable disable. So IMO a setting is not
possible, and it feels a bit poweruser to have a setting for this. IMO
let's just pick what we as a majority feels is the better interaction for
confluence.
On 6 Aug 2014 09:13, "Voyager1" <notifications@github.com> wrote:

> In addons/skin.confluence/720p/VideoOSD.xml:
>
> > @@ -570,7 +570,7 @@
> >  				<texturenofocus border="25,5,25,5">SubMenuBack-MiddleNF.png</texturenofocus>
> >  				<pulseonselect>false</pulseonselect>
> >  				<label>209</label>
> > -				<onclick>NextSubtitle</onclick>
> > +				<onclick>CycleSubtitle</onclick>
>
> it would be nice if there was a user choice between the old behaviour and
> the new one. Apparently, this changes the behavior in the Confluence skin
> and not in the others - it makes no sense. I'd rather keep the same command
> but have a setting determine whether it's "next" or "cycle".
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xbmc/xbmc/pull/5163/files#r15858989>.
>