Wrap username and password in encodeURIComponent to be URL safe.

yes, that is how the chrome extension works also. it isn't awesome that the
password is in the query string; but, aside from trying to write the
extension to fill in the fields on the login page after it loads, which
would be slower, i'm not sure what is to be done.

On Wed, Oct 29, 2014 at 10:30 AM, csobrien <notifications@github.com> wrote:

> In LoginList.js:
>
> > @@ -27,7 +27,7 @@ function buildLoginsList() {
> >              href: '#',
> >              click: function (event) {
> >                event.preventDefault();
> > -              safari.application.activeBrowserWindow.openTab().url = 'https://' + theGlobal.orgTypes[curLogin.type] + '.salesforce.com/?un=' + curLogin.userName + '&pw=' + curLogin.password;
> > +              safari.application.activeBrowserWindow.openTab().url = 'https://' + theGlobal.orgTypes[curLogin.type] + '.salesforce.com/?un=' + encodeURIComponent(curLogin.userName) + '&pw=' + encodeURIComponent(curLogin.password);
>
> Is this the way the Chrome version works? I just hate that the pwd is in
> the query string. That'll end up in browser histories, log files, etc...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sonomapartners/safarisfdclogins/pull/6/files#r19546100>
> .
>