Front End Work

Lots of work here! Each of the commits in this Pull Request has information about what was done. The tl;dr is that we made lots of UI changes for the better. This has been tested in latest versions of Chrome, Firefox, Safari on Mac and it works in Internet Explorer versions 10+. 

Lower versions of IE will need some extra help, but they account for <10% of users so I think this should get us going for MVP. 

Please pull this down and make sure I didn't catastrophically break any Rails bits, but I think not.

Cheers!
is there a real standard and not a change.org standard?  i'm tempted to say
that we should do the opposite of whatever change.org does, unless our goal
is to regularly break our primary product.




On Fri, Jul 4, 2014 at 2:29 PM, Erik Ogan <notifications@github.com> wrote:

> In app/views/downloads/_waiting_for_pdf.html.haml:
>
> > \ No newline at end of file
> > +.col-md-8.col-md-offset-2.col-xs-12
> > +  .row
> > +    .text-center.spacer-sm#ldv-form-progress
> > +      %div.progress-indicator-hr-container
> > +        %hr
> > +      %div#progress-indicator-step1.incomplete
>
> What about DRYing these up? Something like:
>
> - (1..6).each do |i|
>   %div.incomplete{id: "progress-indicator-step#{i}}
>     %a= i
>
> Also, I have picked up a habit we standardized at Change of using
> underscores in ids and dashes in classes. I’m not saying we must do it, but
> we should be consistent. @ericisaiah <https://github.com/ericisaiah> was
> the one who did most of the front-end, so we should do whatever he suggests
> (which I suspect you’re already doing, I just noticed the dashes in the id
> and it stuck out to me.)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/longdistancevoter/bullwinkle/pull/9/files#r14567943>.
>



-- 
Debra Cleaver
www.longdistancevoter.org
917-882-0405

129 million Americans voted in the 2012 Election. 2 million of them visited
Long Distance Voter first. *Can you chip in $5 to help Long Distance Voter
reach another 500,000 voters in 2014?*
<http://www.longdistancevoter.org/donate>