some random style nits

most of these were suggested by intellij but pass a gut check to me; lmk if you there are conventions that we should decide more clearly one way or the other on.
ah yea, I can squint and see there being some savings there.

I'll remove it from the .count ones now, in any case


On Fri, Aug 15, 2014 at 6:47 PM, Arun Ahuja <notifications@github.com>
wrote:

> In src/main/scala/org/bdgenomics/guacamole/pileup/Pileup.scala:
>
> > @@ -78,7 +78,7 @@ case class Pileup(locus: Long, elements: Seq[PileupElement]) {
> >    /**
> >     * Number of positively stranded reads
> >     */
> > -  lazy val positiveDepth: Int = elements.view.filter(_.read.isPositiveStrand).size
> > +  lazy val positiveDepth: Int = elements.view.count(_.read.isPositiveStrand)
>
> Not sure honestly, from what I had read before without .view an
> intermediate seq is created before we get the length, but did not test this
> out.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hammerlab/guacamole/pull/143/files#r16319282>.
>