At the moment, I’m using Notepad++ text editor. 

 

I have used (mostly, if not exclusively) tabs rather than spaces for indentation. Each tab is set to be equivalent to two spaces, but I have NOT checked the ‘replace tabs by spaces’ option.

 

So if you are seeing a lot of white space or deep indentation, perhaps your editor and mine have different tab settings?

 

J

 

From: Thomas Thomassen [mailto:notifications@github.com] 
Sent: 31 January 2014 16:14
To: SketchUp/sketchup-shapes
Cc: johnwmcc
Subject: Re: [sketchup-shapes] Second attempt to commit my updated su_shapes.rb and su_shapes/shapes.rb... (#5)

 

In src/su_shapes/mesh_additions.rb:

> @@ -45,12 +36,12 @@ def add_revolved_points(pts, axis, numsegments)
>  
>      #TODO: Determine if the points are all in the same plane as the axis
>      planar = true
> -
> +    

There is a few lines with dead white-space. Can you eliminate them? What editor do you use?
If you use Sublime Text then you can load the project file I checked in as it'll ensure you have correct settings for white-space etc for this project. If you loaded the project and then hit save in Sublime it should zap all them redundant white-space characters.

—
Reply to this email directly or view it on GitHub <https://github.com/SketchUp/sketchup-shapes/pull/5/files#r9346897> .  <https://github.com/notifications/beacon/6536597__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjcxNzY1OCwiZGF0YSI6eyJpZCI6MjQ2ODkwMzN9fQ==--9ebbe80563d73f3586ae6a692ebc0c6387389451.gif>