clients: ivi-shell-user-interface.c , Remove redundant function calls

> _set_user_data() is redundant here, _add_listener() does it too.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
clients: ivi-shell-user-interface.c, Remove unnecessary do-while

> Using if () {  } else if () { ...
> would let you get rid of one level of indent and the breaks. }

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
clients: ivi-shell-user-interface.c , Fix Invalid value for registry_listener

> NULL here will cause a segfault when the event arrives.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
ivi-shell: ivi-shell.c, Fix surface destructor.

> You cannot do this. The client is destroying the wl_surface, not the
> ivi_surface. Calling wl_resource_destroy() here creates a disagreement
> between the server and the client on what protocol objects exist. It
> inevitably leads to a protocol error if the client attempts to destroy
> the ivi_surface after the wl_surface.
> Instead, you need to detach all listeners etc. from the weston_surface
> here, and set ivisurf->surface = NULL.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
clients: ivi-shell-user-interface.c ,use os_create_anonymous_file when temporary file

> You should use oscreateanonymous_file() instead.
> Here you forget to e.g. unlink the file, and set the file descriptor CLOEXEC.
> Oh hey, my /tmp has 109 files from September from this function, and
> it's not even a tmpfs so they actually ended up on disk. Apparently that
> is the last time I actually tried to run this.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
clients: simple-egl.c,Fix invalid function calling.

> Calling handle_surface_configure() is detrimental here, you are
> confusing
> xdg_shell code paths with ivi_application code paths, and needing to
> modify
> the xdg_shell code path to cope with a bogus call.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>