[MODCLUSTER-414] Fix compilation warnings in the native part (mod_advertise+mod_manager)

https://issues.jboss.org/browse/MODCLUSTER-414

* i think we may want to analyze if these could not have been more severe bugs

mod_advertise part:
* line 89: unused variable (ma_listen_socket)
* line 178: string literals need to be compared using strcmp()
* line 657: wrong format for port %l but port is defined as int
* line 734: wrong format with precision loss, type long int but printed as %d

mod_manager part:

* fix several problems when uninitialized value was returned
On 09/04/2014 05:44 PM, Radoslav Husar wrote:
> In native/mod_manager/balancer.c:
>
>> @@ -168,9 +168,9 @@ apr_status_t remove_balancer(mem_t *s, balancerinfo_t *balancer)
>>  {
>>      apr_status_t rv;
>>      balancerinfo_t *ou = balancer;
>> -    if (balancer->id)
>> -        s->storage->ap_slotmem_free(s->slotmem, balancer->id, balancer);
>> -    else {
>> +    if (balancer->id) {
>> +        rv = s->storage->ap_slotmem_free(s->slotmem, balancer->id, balancer);
>
> This function is never used, thus the return value is never used. Should
> this be kept around?

Well better keep it for the moment.


>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/modcluster/mod_cluster/pull/89/files#r17121717>.
>