[445179] Fix original Draw2D bendpoint copy

The Draw2D bendpoints original locations were saved by copying a list.
Therefore, the list elements could be changed during the feedback. This
lead to a wrong restoration of the edge if a reconnection failed
(reconnected to a non candidate target). Note that this issue was
visible only if the GMF coordinates were broken, because Draw2D has to
compute coordinates.

Bug: 445179
Change-Id: I5226e7298bf812a906f0760f514ebbdb16192e44
Signed-off-by: Steve Monnier <steve.monnier@obeo.fr>
[449220] Add missing tests for undo/redo on popupmenu actions

Bug: 449220
Change-Id: Ifd5e584f4b3f0421110f98b8d0446d7138688fe6
Signed-off-by: Belqassim Djafer <belqassim.djafer@obeo.fr>
[445603] Return the result IStatus from DAnalysisSessionImpl.doSave()

Return the result of the save operation that may contain an exception
internally launched. The result can be used by the caller to analyze
errors during the save. 

Indeed, exceptions that may be thrown during the save are no longer
propagated to the caller. So this fix allows sub-classes to have access
to the IStatus and react to it if they want to.

Bug: 445603
Change-Id: I858214108cf368397fc8c12697954de9150cbf41
Signed-off-by: Mickael LANOE <mickael.lanoe@obeo.fr>
[444578]  Fix Manifest file generated by VSP wizard

Modification of the specified execution environment in Manifest content
(generated by VSP wizard) should be the default one.

Bug: 444578
Change-Id: I407183a2cd6091748ec5ebeaa3de704898927f54
Signed-off-by: Jessy Mallet <jessy.mallet@obeo.fr>
[build] Test TP for mars should consume mars repositories

and not luna ones.

Change-Id: I088f415d633a06ef54ebb7b5e4e08c37ddf91b2c
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[448739] Use reliable source and target bounds as possible.

* Compute the source and target edge absolute bounds is not reliable in
GMF. When we have those bounds at figure layer, we use them.
* This patch fixes an issue when resizing an auto-size container. see Comment #5[1]

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=448739#c5

Bug: 448739
Change-Id: I0deab43f7340a07c4573b9506df052dc06e67caa
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
[448739] Adapt the rectilinear router for GMF Edge.

* The Rectilinear router handles bendpoints that are within the new source or target bounds. That fixes the issue explained in Comment 8 [1]
* Create a new getIntersecctionPoints method within GraphicalHelper that doesn't need to know the minimalDistancefromLineOrigin.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=448739#c8

Bug: 448739
Change-Id: Ibc39d9bec52e251aee9af7a57dda7f924075642f
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
[448739] Perform the ShiftEdgeIdentityAnchorOperation for centered
edges.

* This action was disabled because it brokes the edge centering. Since we
perform the edge centering during the resize and after the
ShiftEdgeIdentityAnchorOperation, we can enable it again.
* This patch fixes also a wrong behavior with the centering property.
(see comment 10 [1]) Without the ShiftEdgeIdentityAnchorOperation
execution, the "from source" and the "from target" bendpoint locations
are different.
* Add a new Test that checks this issue but also the one described
within the comment 8 [2].

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=448739#c10
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=448739#c8

Bug: 448739
Change-Id: I451d110ef67f2efb2a4a6f6aba90f62844ca18e1
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
[448739] Forbid centered edge end moving on rectilinear edge

* In case of a rectilinear edge with only two bendpoints, if one of its
end was centered, the user was able to move the other end but that
causes the entire segment moving. If one of the edge end is centered, we
now forbid to move all ends for rectilinear edges with only one segment.
* This commit fixes the comment 1 [1]
* This commit includes additional tests to check this behavior.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=448739#c1

Bug: 448739
Change-Id: I4a2e3ec8fbc2be1c6557c50307be83c4366b03d5
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
[cleanup] Remove ISelectionListener inheritance of tree/table dialect
editor

Remove ISelectionListener inheritance of tree/table dialect editor as
the ISelectionListener.selectionChanged() implementation do nothing.
This code is commented since a long time, 26/05/2010 and was at this
time in AbstractDTableEditor class and was doing nothing also.

Change-Id: Ic1a919b6198daba24c3cf976ead08970ee1c2ea5
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[cleanup] Remove the useless SessionFactoryImpl.exists() method

Remove the useless SessionFactoryImpl.exists() method as now we can use
URIConverter.exists()

Change-Id: Ia9669cf43884b15a1e9ac39e5e7e1982955673f4
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[cleanup] Remove unused PaletteManagerUpdater class

Remove unused PaletteManagerUpdater class

Change-Id: If4449955f43743a254c71e7a6e96dc74ff3432a5
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[447945] Report permission checks from Node to Container.

Some complementary checks have been made on Node in [1] but have not
been reported for Container in [2].
This difference has been introduce since 13/10/2010.

[1]
org.eclipse.sirius.diagram.tools.internal.command.builders.NodeCreationCommandBuilder
[2]
org.eclipse.sirius.diagram.tools.internal.command.builders.ContainerCreationCommandBuilder

Bug: 447945
Change-Id: I053b2488bf57716a72f29bdcc52390dd9828eadd
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[cleanup] Clean code as in previous commit de9012f with similar code

Change-Id: I345a270a4dca301591908e5a473ba63a42cf0e30
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[test] Add "-XX:+HeapDumpOnOutOfMemoryError" vm parameter

Add "-XX:+HeapDumpOnOutOfMemoryError" vm parameter to be able to analyse
potential OutOfMemory from Jenkins.

Change-Id: I4539500e68380b1f763f3be7211f3694fcd86e50
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>