It won't matter how many active users, the call is from RateLimitManager which is application scoped. So there should only be one message per change. Unless someone firing massive REST request to update the value. But we would stop that with the limit itself though. 

----- Original Message -----

> From: "Sean Flanigan" <notifications@github.com>
> To: "zanata/zanata-server" <zanata-server@noreply.github.com>
> Cc: "Patrick Huang" <pahuang@redhat.com>
> Sent: Tuesday, March 18, 2014 2:14:12 PM
> Subject: Re: [zanata-server] rhbz988202 - RFE: REST API rate limiting (#390)

> In zanata-war/src/main/java/org/zanata/servlet/RestRateLimiter.java:
> > +        limitConfig = newLimitConfig;
> > +    }
> > +
> > +    protected synchronized void changeConcurrentLimit(int maxConcurrent) {
> > +        log.info("max concurrent limit changed: {}", maxConcurrent);
> > +        maxConcurrentSemaphore = new Semaphore(maxConcurrent);
> > +    }
> > +
> > +    protected synchronized void changeRateLimitPermitsPerSecond(double
> > permits) {
> > +        log.info("rate limit changed: {}", permits);
> > +        rateLimiter.setRate(permits);
> > +    }
> > +
> > +    protected synchronized void changeActiveLimit(int oldLimit, int
> > newLimit) {
> > +        this.change = new ActiveLimitChange(oldLimit, newLimit);
> > +        log.info("max active limit changed: {}", change);

> I think these log INFO messages could be overwhelming (see also the methods
> above), if we have a lot of API users active when the limits are adjusted.

> —
> Reply to this email directly or view it on GitHub .