The internet at my home just cut out, so I'm having trouble verifying why.
Could you explain briefly? Seems like it should be fine.
On Feb 24, 2014 10:34 PM, "zhanggl" <notifications@github.com> wrote:

> In
> finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/Reply.scala:
>
> >      RequireServerProtocol.safe {
> >        NumberFormat.toInt(line)
> >      } match {
> > -      case empty if empty < 1 => emit(EmptyBulkReply())
> > +      case empty if empty < 0 => emit(EmptyBulkReply())
> > +      case 0 => //Here we got an empty string: '$0\r\n\r\n' -> '""'
>
> I'm afraid it is. A readBytes(replySz) with replySz=0 will cause an
> Exception to be thrown.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/twitter/finagle/pull/245/files#r10023324>
> .
>