refactor Roles controller