worked on is-subset