add asset management modules

Florian,

 

I am impressed by the thoroughness of your code review. 

It should indeed be ‘init_entry’ in stead of ‘init’ and you can find this out only by reading the code (since there are no cases in the current version of this module where the ‘init_entry’ field can be  modified without any of the other trigger fields). 

 

I have changed ‘init’ into ‘init_entry’ in the meanwhile.

 

Thanks,

Luc

 

 <http://www.noviat.com/> www.noviat.com

Rusatiralaan 1, 1083 Brussel

+32 2 808 86 38

 



 

From: florian-dacosta [mailto:notifications@github.com] 
Sent: maandag 27 oktober 2014 18:32
To: OCA/account-financial-tools
Cc: luc-demeyer
Subject: Re: [account-financial-tools] add asset management modules (#51)

 

In account_asset_management/account_asset.py:

> +                    _get_assets,
> +                    ['purchase_value', 'salvage_value', 'parent_id'], 10),
> +            },
> +            help="This amount represent the initial value of the asset."),
> +        'value_residual': fields.function(
> +            _residual, method=True,
> +            digits_compute=dp.get_precision('Account'),
> +            string='Residual Value',
> +            store={
> +                'account.asset.asset': (
> +                    _get_assets, [
> +                        'purchase_value', 'salvage_value',
> +                        'parent_id', 'depreciation_line_ids'
> +                    ], 20),
> +                'account.asset.depreciation.line': (
> +                    _get_assets_from_dl, ['amount', 'init', 'move_id'], 20),

Hello, 
I think it should be 'init_entry' instead of 'init' since there is no field named 'init' in account.asset.depreciation.line.

Thanks for your great work!

—
Reply to this email directly or view it on GitHub <https://github.com/OCA/account-financial-tools/pull/51/files#r19421666> .  <https://github.com/notifications/beacon/AHWZQdx9c_MsPVX5O2OKXalXCRNFl6uOks5nHnkogaJpZM4CpKrQ.gif>