Fix stream closing when sending file with `ActionController::Live` included.

Fixes #12381
Remove warnings in test suite

lib/active_record/store.rb:79: warning: method redefined; discarding old color=
lib/active_record/store.rb:79: warning: previous definition of color= was here
lib/active_record/store.rb:83: warning: method redefined; discarding old color
lib/active_record/store.rb:83: warning: previous definition of color was here
Merge pull request #13616 from zirni/remove_warnings

Remove warnings in test suite
activerecord: Initialize Migration with version from MigrationProxy.
Add 'e' var on rescue DalliError, in order to log it
Merge pull request #13617 from arthurnn/error_var

Add 'e' var on rescue DalliError, in order to log it
Use a better method name to check the requirement of password confirmation

Also improve changelog entries related to secure password to proper
highlight.
Make change_table use object of current database adapter

  - Earlier, change_table was creating database-agnostic object.
  - After this change, it will create correct object based on current
    database adapter.
  - This will ensure that create_table and change_table will get same objects.
  - This makes update_table_definition method public and nodoc.
  - Fixes #13577 and #13503
Merge pull request #13597 from prathamesh-sonpatki/hstore_migration

Make change_table use object of current database adapter
Fix typo in image_tag documentation

image_tag only supports :alt and :size as additional keys, not three.
Merge pull request #13621 from Intrepidd/patch-1

Fix typo in image_tag documentation [ci skip]
Merge pull request #13355 from dylanahsmith/migration-version

activerecord: Initialize Migration with version from MigrationProxy.

Conflicts:
	activerecord/CHANGELOG.md
`core_ext/string/access.rb` test what we are documenting.

I also extracted the tests from a single bulk method into a separate test-case.
The new tests cover the API described in the docs.

There are two skipped tests, which are broken as of 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3
* #to with negative Fixnum, position is counted from the end
* #from and #to can be combined

This was brought to my attention by #13627.

Closes #13627.
typo fix in test name. [ci skip].
Revert "Speedup String#to"

This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3.

As described in PR #13627 this commit broke functionality when passing
a negative Fixnum to the `String#to` method:

```ruby
assert_equal "hell", s.to(-2)
```

Before the revert, this failed with:

```
  1) Failure:
StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]:
Expected: "hell"
  Actual: nil
```

This revert is to keep the functionality on `master` working.
If there is another way to get the performance benefit and keep
the documented functionality we can add that.

/cc @amatsuda @carlosantoniodasilva
create/drop test and development databases only if RAILS_ENV is nil

Closes #13625
Merge pull request #13629 from dmathieu/drop_test

Be more explicit about the default of db:drop and db:create
make `change_column_null` reversible. Closes #13576.

Closes #13623.
Minor typos fix [ci skip]
Move finish_template as the last public method in the generator