Whitespace, code layout and guidelines
Code cleanup in bug_report.php

- Move $f_rel_type init to where others form vars are set
- Remove duplicate initialization of form variable $f_master_bug_id
- Use defined $t_project_id instead of $t_master_bug->project_id
- Replace hardcoded numbers with relationship constants
Allow Reporters to Clone issues

Previously, users needed to have update_bug_threshold to be able to
clone issues, since the creation of a relationship with the parent bug
requires to update it.

This patch lets Reporters clone issues and allows them to create a
relationship with the parent, even if they lack updater access.

Fixes #11290 (implements option 3)
Correct comparison operator
Allow Reporters to Clone issues

Pull request #130
View Filters page HTML/CSS fixes
Project filter display [] around  'current'

For consistency with other meta filters like [any], [myself], we now
display '[current]' instead of 'current'
Project filters: fix preselection of current filter

The strict type checking for check_selected must be disabled when
dealing with projects/subprojects selection lists display. The
alternative (strict checks + type casts) prevents the current filter
from being preselected when editing it.
Fix type issues with check_selected in view_filter_page.php
Fix strict type issues (check_selected) in filters

Use of strict type checking for check_selected() must be disabled when
dealing with projects/subprojects selection lists display. The
alternative (strict checks + type casts) prevents the current filter
from being preselected when editing it, and also causes occasional
errors when displaying the filters.

Also includes HTML/CSS fixes.

Pull request #132
Changed position and label of 'Changed(Hrs)' filter

This setting is actually not a filter but a display option that
just highlights the last updated date. The field has been moved next to
'Sort by', and its label changed to reflect its real function.

Fixes #7737

This is a port of the original 1.2.x commits from the pull request
(squashed).

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Move 'Highlight changed' field in view_filters_page.php
Changed(hrs) "filter" is now labeled 'Highlight changed'

Pull request #81
Change default from mysql to mysqli

The mysql extension is deprecated as of PHP 5.5.0 [1] so we use mysqli
as our default database type.

Commit includes relevant changes in installer, admin checks and
documentation (admin guide).

Fixes #16941

[1] http://php.net/intro.mysql
db_prepare_string() remove special handling for mysql

Since ADOdb's qstr() method calls mysql_real_escape_string() /
mysql_real_escape_string() depending on driver type, it does not make
sense to have special logic within database api to handle mysql
differently from mysqli. Let ADOdb quote the string.
Update ADOdb to latest 5.19dev

Using development release as it contains fixes over official 5.18 which
are required for MantisBT to work properly, and John Lim (ADOdb author)
is not responding to repeated requests to release 5.19.
Added constant for ADOdb minimum version

Modified installer and admin checks page to use the new constant
Fix admin checks for mysqli table and field collation

The mysqli driver returns field names in lowercase for SHOW TABLE STATUS
whereas mysql uses an uppercase first letter.

Fixes #16968
Install: fix variable names in generated config file

The config_inc.php file generated by the installer had incorrect
variable names for the table prefix and suffix, missing the 'g_'.

Fixes #16966
Admin checks: added test for db_table_plugin_prefix

We now display the current value (like we do for the other 2 variables),
and display a warning when it is empty.

Fixes #16969