[Form][2.3] Fixes empty file-inputs getting treated as extra field.
bug #10251 [Form][2.3] Fixes empty file-inputs getting treated as extra field. (jenkoian)

This PR was squashed before being merged into the 2.3 branch (closes #10251).

Discussion
----------

[Form][2.3] Fixes empty file-inputs getting treated as extra field.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8575 (https://github.com/symfony/symfony/pull/8575#issuecomment-34867485)
| License       | MIT

Re-applies 968fe23 (PR #8575).

The test for this already exists, it was just this line that got overwritten by https://github.com/symfony/symfony/commit/eb9f76d5bad120c1d4b3b30c2d8c73bb9d5928e8#diff-ca5e25b47f3ecc94cd557946aeb486c6L542

To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: https://github.com/symfony/symfony/pull/9146)

Commits
-------

8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
Add tests for RequestStack class
minor #10326 [HttpFoundation][Tests] Add tests for RequestStack class (inalgnu)

This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10326).

Discussion
----------

[HttpFoundation][Tests] Add tests for RequestStack class

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

6f25d39 [HttpFoundation][Tests] Add tests for RequestStack class
[HttpKernel] fixed CS
[HttpFoundation] removed test file not related to 2.3
minor #10372 [HttpKernel] fixed CS (fabpot)

This PR was merged into the 2.3 branch.

Discussion
----------

[HttpKernel] fixed CS

Commits
-------

7539e41 [HttpKernel] fixed CS
[Yaml] fix for a HHVM bug
made Cookie stringification more robust
minor #10380 fixed some HHVM bugs (fabpot)

This PR was merged into the 2.3 branch.

Discussion
----------

fixed some HHVM bugs

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This is a workaround for facebook/hhvm#1161. I made the change as the workaround does the same thing and the eval is part of unit tests.

Commits
-------

d014dac made Cookie stringification more robust
fa24749 [Yaml] fix for a HHVM bug
10158 get vary multiple
bug #10382 10158 get vary multiple (bbinkovitz)

This PR was squashed before being merged into the 2.3 branch (closes #10382).

Discussion
----------

10158 get vary multiple

| Q                     | A
| -------------       | ---
| Bug fix?           | yes
| New feature?   | no
| BC breaks?      |  no
| Deprecations? | no
| Tests pass?     | yes
| Fixed tickets    | [#10158]
| License            | MIT
| Doc PR            | none

Commits
-------

3a4a3cb 10158 get vary multiple
[HttpFoundation] added some unit tests
[Process] Use assertSame instead of assertEquals to avoid comparison against `null`
[Process] Fix process status in TTY mode

When running a process with TTY mode, status in automatically set to `terminated`
once it's started.

It's wrong for two reasons :
 - The status of the process is not yet terminated.
 - The exitcode value is never caught
minor #10411 [Process] Fix comparisons against process exitcode (romainneutron)

This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix comparisons against process exitcode

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Use identical comparison instead of equal. In case the exitcode has not been caught, `Process::isSuccessful` returns true instead of false. It should not happen, but it's much more clean like that.

Commits
-------

d66f63f [Process] Use assertSame instead of assertEquals to avoid comparison against `null`
bug #10412 [Process] Fix process status in TTY mode (romainneutron)

This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix process status in TTY mode

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

When running a process with TTY mode, status in automatically set to `terminated`
once it's started.

It's wrong for two reasons :
 - The status of the process is not yet terminated.
 - The exitcode value is never caught

Commits
-------

51c70f8 [Process] Fix process status in TTY mode
[Process] Make process tests more accurate on exception messages
minor #10419 [2.3][Process] Make process tests more accurate on exception messages (romainneutron)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][Process] Make process tests more accurate on exception messages

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

I need exception message to be checked more accurately in my upcoming PR about windows.
I decided to make a separated PR as the other one will probably take some time before being merged

Commits
-------

1b1768a [Process] Make process tests more accurate on exception messages
[Process] Fix some unit tests that create the process object instead of delegate it to the implementation