adding editing for attributes...incomplete