+1


On Thu, Feb 13, 2014 at 9:03 AM, Jai Ram Rideout
<notifications@github.com>wrote:

> In bipy/maths/stats/ordination/base.py:
>
> > +                                    ('eigvals', 'objects', 'descriptors',
> > +                                     'biplot', 'site_constraints'))):
> > +    __slots__ = ()
> > +
> > +    def __new__(cls, eigvals, objects, descriptors=None, biplot=None,
> > +                site_constraints=None):
> > +        return super(OrdinationResults2, cls).__new__(cls, eigvals, objects,
> > +                                                      descriptors, biplot,
> > +                                                      site_constraints)
> > +
> > +
> > +class Ordination(object):
> > +    short_method_name = 'Overwrite in subclass!'
> > +    long_method_name = 'Overwrite in subclass!'
> > +
> > +    def biplot(self, scaling=2, choices=[0, 1]):
>
> Probably shouldn't define a list (mutable) as a default parameter- maybe
> have a default of None, in which case you can set choices to [0, 1]within the method? See
> http://docs.python-guide.org/en/latest/writing/gotchas/
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/biocore/bipy/pull/90/files#r9714340>
> .
>