not calling update properly