am I doing this right