finished adding attributes, starting to write unittest