Use the new buildpack installer task
Restore max_package_size in the config template

The recent refactor to pull cc templates out of cf-release reverted a
change to support large application packages.
Merge pull request #188 from fraenkel/addbuildpacks

Inject the new buildpack installer task
Remove dead code related to prioritized buildpacks

[#68432850]

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Need to call destroy to exercise after_destroy

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Extract BuildpackPositioner

An attempt to reduce the logic in Buildpack and eventually write clearer specs around the positioning

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Encapsulate shift_to_position in update

- update was the only method using shift_to_position
- there was a second (sorta nested) transaction that was not needed
- [#68432850]

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Reduce knowledge about the db in positioner

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Be defensive about hash key style

buildpack_contoller_spec.rb uses string keys but buildpack_installer.rb symbolizes keys, it is not clear which is correct
Positioner no longer know about Buildpack.db
Split responsibilities of calculating position and shifting

In an attempt to marginally improve clarity. They are not unit tested as they are, and are instead exercised via buildpack_spec
Clean up in drain script

Including better logging

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Add more logging and DRY up router deregister

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Hoist timeout values to the top, trim comments

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Merge branch 'pr/196'
Remove unused exceptions, extract the rest to their files

- One class per file makes discoverability earlier
- This is a tiny step that lets us address [#68482028]
Disallow setting an app to zero instances

When instances is zero strange things happen, and if you want no instances you should just stop your app!
We also changed the default so no one has to set this explicitly.

Signed-off-by: Eric Malm <emalm@pivotallabs.com>
Encrypted attribute spec handles non-exception-raising case

* Decrypting with the wrong encryption key is not guaranteed
to raise a CipherError. In the case where the decrypt succeeds,
we check that the decrypted value does not match the original plaintext.

* We intend this to fix the flakiness of this test, especially in Travis runs.

Signed-off-by: Chris Adams <cadams@pivotallabs.com>
send build artifacts upload/download uri to diego

Signed-off-by: Phan Le <ple@pivotallabs.com>
add CF_DIEGO_BETA env var to opt into diego