This is the error callback. Does that change the clarity of the code?


On Fri, May 30, 2014 at 10:15 AM, Joe Hudson <notifications@github.com>
wrote:

> In src/loading.js:
>
> > @@ -312,12 +312,20 @@ function loadData(callback, failback, options) {
> >        routeChanged = false,
> >        successCallback = bindToRoute(_.bind(callback, self), function() {
> >          routeChanged = true;
> > -        if (self._request) {
> > +
> > +        // Manually abort this particular load cycle (and only this one)
> > +        queueEntry && queueEntry.aborted();
>
> can you put a little more comments about why we need to manually abort
> here on the success callback?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/walmartlabs/thorax/pull/372/files#r13230330>.
>