It should not harm.


On Wed, Jan 29, 2014 at 9:50 AM, Andreas Zelend <notifications@github.com>wrote:

> In xbmc/cores/omxplayer/OMXPlayer.cpp:
>
> > @@ -3105,10 +3101,18 @@ bool COMXPlayer::GetSubtitleVisible()
> >
> >  void COMXPlayer::SetSubtitleVisible(bool bVisible)
> >  {
> > -  CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleOn = bVisible;
>
> right. Will revert it. Does the duplicate assignment, first here and then
> in _SetSubtitleVisible harm? I don't think so. Or should I leave the
> message handling like it was?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/4084/files#r9259339>
> .
>