Remove skill_set_iter.

It wasn't even a const_iterator, so several functions unnecessarily
rejected const skill sets.  Use range-based fors where possible, and
auto in the single case that requires an iterator.