1) Agree on platfom-independent way. Why do not we propagate port number
configuration to zeppelin-env.sh? So this ZEPPELIN_PORT variable is aways
available?

2) To keep things simple - i do not see why not to make shell script return
ONLY after the server is loaded.
This simplifies things a lot and keep things as cross platform as they are
right now with sell scripts.
I think this can be easily archived exiting main() only after server is
loaded with no real downsides (startup time is really sort)
What do you think?


On Tue, Jan 14, 2014 at 9:59 AM, Lee moon soo <notifications@github.com>wrote:

> In bin/zeppelin-daemon.sh:
>
> >  	echo "full log in $log"
> >      fi
> >
> > +    if [ "${CI}" == "true" ]; then  # if it is CI wait until server is up and running and ready to serve.
>
> 1) because on production env, user can change port number. Maybe we can
> detect port number from process id, but i don't know platform independent
> way of doing that, yet.
>
> 2) So the implemented way in this condition is check server port and
> waiting for '200 OK'.
> But usually most daemon script does not wait for server actually running.
>
> To apply this always, we need platform independent way. a) we need to detect port number. b) we can not use curl, while some platform might not have curl installed. instead of doing curl, we can implement some signal handler and check server status using signal can be alternative.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NFLabs/zeppelin/pull/26/files#r8847632>
> .
>



-- 
--
Kind regards,
Alexander.