Various

Most of this was just trying to make sense of subscriptions, and I failed !  

Mostly restructuring and moving a few more subscription  querys to the subs.  Combined a couple of the subscription subs but more can be done.  For some reason that code does not work well with my brain, ever get code like that?  It just does not flow for me, but some of that is just understanding what it does.  Not sure I really fixed anything :frowning: 

Tried to put a version of the member group fix reported wrt removing group access when subscriptions are deleted that was reported at smf.

Moved some external karma functions back as private functions of the karma controller and added a new no smite option so its like our no unlike notification, no negatives style approach.

Bunch of basic cleanup in associated functions.