The default value is True.  so you're saying I should remove the
'raise_error=True' paramater for the 3rd test case so it invokes the
default value?  hmm.. i can see why you're asking for this..  sure.


On Thu, Mar 20, 2014 at 11:39 AM, David Baumgold
<notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/tests/test_tabs.py:
>
> > +
> > +class KeyCheckerTestCase(unittest.TestCase):
> > +    """Test cases for KeyChecker class"""
> > +
> > +    def setUp(self):
> > +
> > +        self.valid_keys = ['a', 'b']
> > +        self.invalid_keys = ['a', 'v', 'g']
> > +        self.dict_value = {'a': 1, 'b': 2, 'c': 3}
> > +
> > +    def test_key_checker(self):
> > +
> > +        self.assertTrue(tabs.key_checker(self.valid_keys)(self.dict_value, raise_error=False))
> > +        self.assertFalse(tabs.key_checker(self.invalid_keys)(self.dict_value, raise_error=False))
> > +        with self.assertRaises(tabs.InvalidTabsException):
> > +            tabs.key_checker(self.invalid_keys)(self.dict_value, raise_error=True)
>
> You explicitly set raise_error every time. Can you try this function
> without setting it, so that you're testing the default value, as well?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/2910/files#r10800283>
> .
>



-- 

edX | nasthagiri@edx.org <andya@edx.org>

141 Portland Street, 9th floor

Cambridge, MA 02139
http://www.edx.org <http://www.edxonline.org/>

[image:
http://www.e-learn.nl/media/blogs/e-learn/edX_Logo_Col_RGB_FINAL.jpg?mtime=1336074566]